Page MenuHomePhabricator

TestLiveCosmeticChanges.test_cleanUpLinks_pipes_fail erroneously doesn't fail unittest
Closed, ResolvedPublic

Description

removing unittest.expectedFailure it fails as expected and should be fixed:

C:\pwb\GIT\core>pwb.py tests/cosmetic_changes_tests -v TestLiveCosmeticChanges.test_cleanUpLinks_pipes_fail
tests: max_retries reduced from 25 to 1
test_cleanUpLinks_pipes_fail (__main__.TestLiveCosmeticChanges)
Test cleanUpLinks method. ... FAIL

======================================================================
FAIL: test_cleanUpLinks_pipes_fail (__main__.TestLiveCosmeticChanges)
Test cleanUpLinks method.
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".\tests\cosmetic_changes_tests.py", line 261, in test_cleanUpLinks_pipes
_fail
    self.cct.cleanUpLinks('[[title|Title]]'))
AssertionError: u'[[Title]]' != u'[[Title|Title]]'
- [[Title]]
+ [[Title|Title]]
?   ++++++


----------------------------------------------------------------------
Ran 1 test in 1.620s

FAILED (failures=1)