TestLiveCosmeticChanges.test_cleanUpLinks erroneously doesn't fail unittest
Open, HighPublic
Actions

Assigned To

None

Authored By

	Xqt
	Mar 25 2016, 12:24 PM

Description

removing unittest.expectedFailure it fails as expected and should be fixed:

C:\pwb\GIT\core>pwb.py tests/cosmetic_changes_tests -v TestLiveCosmeticChanges.t
est_cleanUpLinks
tests: max_retries reduced from 25 to 1
test_cleanUpLinks (__main__.TestLiveCosmeticChanges) ... FAIL

======================================================================
FAIL: test_cleanUpLinks (__main__.TestLiveCosmeticChanges)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".\tests\cosmetic_changes_tests.py", line 280, in test_cleanUpLinks
    self.cct.cleanUpLinks('text[[ title ]]text'))
AssertionError: u'text [[title]] text' != u'text [[title ]]text'
- text [[title]] text
?               -
+ text [[title ]]text
?             +


----------------------------------------------------------------------
Ran 1 test in 1.987s

FAILED (failures=1)

C:\pwb\GIT\core>

Related Objects
Search...

Status	Assigned	Task
Open	None	T152961 Improve tests suite
Open	None	T129368 Usages of unittest.expectedFailure or unittest.skip should be solved (goal)
Open	None	T130918 TestLiveCosmeticChanges.test_cleanUpLinks erroneously doesn't fail unittest

Event Timeline

Xqt created this task.Mar 25 2016, 12:24 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptMar 25 2016, 12:24 PM

Xqt added a parent task: T129368: Usages of unittest.expectedFailure or unittest.skip should be solved (goal).Mar 25 2016, 12:24 PM

Broken test:

self.assertEqual('text [[title]] text',
                 self.cct.cleanUpLinks('text[[ title ]]text'))
self.assertEqual('text [[title|name]] text',
                 self.cct.cleanUpLinks('text[[ title | name ]]text'))
self.assertEqual('text[[title|name]]text',
                 self.cct.cleanUpLinks('text[[ title |name]]text'))
self.assertEqual('text [[title|name]]text',
                 self.cct.cleanUpLinks('text[[title| name]]text'))

Live code:

if not trailingChars:
    labelLength = len(label)
    label = label.rstrip()
    hadTrailingSpaces = len(label) != labelLength

The results are instead:

text [[title ]]text - the space cannot be moved outside because of if not trailingChars:
text [[title|name ]]text - same bug
text[[title|nametext]] - linktrail goes inside the text
text [[title|nametext]] - same bug

Fix for the last two is trivial, but the first two require some brainstorming because MediaWiki parses [[title ]]text to [[title|title text]], not [[title]] text which is the intended result.

Xqt triaged this task as High priority.Dec 1 2017, 5:07 AM

Dvorapa moved this task from Backlog to Test failures on the Pywikibot-tests board.May 20 2018, 12:02 PM

TestLiveCosmeticChanges.test_cleanUpLinks erroneously doesn't fail unittestOpen, HighPublicActions

Description

Related ObjectsSearch...

Event Timeline

TestLiveCosmeticChanges.test_cleanUpLinks erroneously doesn't fail unittest
Open, HighPublic
Actions

Related Objects
Search...