Page MenuHomePhabricator
Create Task
Maniphest T130939

Use consistent parameter and variable names in DI
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Inconsistency == unnecessary cognitive load.

Deprecate paymentmethod, submethod, and currency in favor of payment_method, payment_submethod, and currency_code.

Update: We had to fix all the incoming links because they were populating payment_method with a weird dotted version. Now that that's done, delete the legacy code.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update rtbt link for new parametersmediawiki/vagrantmaster+1 -1
Remove deprecated parametersmediawiki/extensions/DonationInterfacemaster+13 -57
Prefer canonical parameter names in form choosermediawiki/extensions/DonationInterfacemaster+47 -8
Customize query in gerrit

Event Timeline

Ejegg created this task.Mar 25 2016, 5:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2016, 5:28 PM
gerritbot subscribed.Mar 25 2016, 5:54 PM

Change 279641 had a related patch set uploaded (by Ejegg):
Prefer canonical parameter names in form chooser

https://gerrit.wikimedia.org/r/279641

gerritbot added a project: Patch-For-Review.Mar 25 2016, 5:54 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Freshmaking board.Mar 25 2016, 5:54 PM
Ejegg set the point value for this task to 1.
• DStrine moved this task from Triage to Current Sprint & Completed in Q3 1516 on the Fundraising-Backlog board.Mar 28 2016, 4:26 PM
gerritbot added a comment.Mar 28 2016, 9:30 PM

Change 279641 merged by jenkins-bot:
Prefer canonical parameter names in form chooser

https://gerrit.wikimedia.org/r/279641

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)).Mar 28 2016, 10:00 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Freshmaking board.Mar 29 2016, 4:49 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Freshmaking board.Mar 29 2016, 11:50 PM
Ejegg added a comment.Mar 30 2016, 9:49 PM

Next step: delete the legacy code

Ejegg updated the task description. (Show Details)Mar 30 2016, 9:52 PM
Ejegg changed the point value for this task from 1 to 2.
Ejegg moved this task from Done to Doing on the Fundraising Sprint Freshmaking board.
• DStrine moved this task from Current Sprint & Completed in Q3 1516 to Current Sprint & Completed in Q4 1516 on the Fundraising-Backlog board.Mar 30 2016, 10:06 PM
• DStrine added a project: Fundraising Sprint Ghostbusting .Mar 30 2016, 10:39 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Ghostbusting board.Mar 30 2016, 10:56 PM
gerritbot added a comment.Mar 31 2016, 5:55 PM

Change 280696 had a related patch set uploaded (by Ejegg):
Remove deprecated parameters

https://gerrit.wikimedia.org/r/280696

gerritbot added a comment.Mar 31 2016, 5:58 PM

Change 280697 had a related patch set uploaded (by Ejegg):
Update rtbt link for new parameters

https://gerrit.wikimedia.org/r/280697

Ejegg moved this task from Doing to Review on the Fundraising Sprint Ghostbusting board.Mar 31 2016, 5:58 PM
gerritbot added a comment.Mar 31 2016, 6:16 PM

Change 280696 merged by jenkins-bot:
Remove deprecated parameters

https://gerrit.wikimedia.org/r/280696

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)).Mar 31 2016, 7:00 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Ghostbusting board.Apr 1 2016, 5:37 PM
gerritbot added a comment.Apr 1 2016, 10:32 PM

Change 280697 merged by jenkins-bot:
Update rtbt link for new parameters

https://gerrit.wikimedia.org/r/280697

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Ghostbusting board.Apr 5 2016, 5:42 PM
Ejegg closed this task as Resolved.Apr 11 2016, 4:25 PM
• DStrine removed a project: Unplanned-Sprint-Work.Apr 14 2016, 6:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits