Page MenuHomePhabricator

ZeroPortal in extension-gate causing mediawiki to fail
Closed, ResolvedPublic

Description

Steps to reproduce

  • Click on the failed test and view the error.

It says this

15:06:33 ........................................................... 3068 / 11290 ( 27%)
15:06:33 ................[Thu Mar 24 15:06:33 2016] [hphp] [26875:7f7f53404d00:0:000001] []
15:06:33 Fatal error: unknown class Scribunto_LuaLibraryBase in /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/ZeroPortal/includes/LuaLibrary.php on line 13
15:06:33 Build step 'Execute shell' marked build as failure
15:06:33 Recording test results
15:06:33 [PostBuildScript] - Execution post build scripts.
15:06:33 [mediawiki-extensions-hhvm] $ /bin/bash -xe /tmp/hudson6176958882203842405.sh
15:06:33 + /srv/deployment/integration/slave-scripts/bin/mw-teardown-mysql.sh
15:06:33 Archiving artifacts
15:06:34 Finished: FAILURE

Actual results

  • It fails with it needs scribunto for one of the files. Scribunto wont be in extension-gate until its performance is improved.

Expected results

  • If scribunto is not available the file that needs scribunto should be skipped and not loaded.

Event Timeline

@Addshore since you found out this error can I add you to task please.

If scribunto is not available the file that needs scribunto should be skipped and not loaded.

Looking at all of the code this isn't really possible, it seems the whole extension requires it.

Either ZeroPortal should removed from the job or Scribunto should be added

The description says Scribunto will not be added thus ZeroPortal must be removed

MaxSem assigned this task to JanZerebecki.
MaxSem subscribed.

Was resolved ages ago.