Page MenuHomePhabricator

Remove redundant entries from wgNamespacesAliases
Closed, ResolvedPublic

Description

I think I see most entries there that are not needed or redundant since they match with the defaults. Things such as:

'+abwiki' => array( 'Wikipedia' => NS_PROJECT, ),

are IMHO redundant as the defaults should do it:

	// defaults to aid when things are switched
	'+wikibooks' => array( 'Wikibooks' => NS_PROJECT ),
	'+wikinews' => array( 'Wikinews' => NS_PROJECT ),
	'+wikiquote' => array( 'Wikiquote' => NS_PROJECT ),
	'+wikisource' => array( 'Wikisource' => NS_PROJECT ),
	'+wikiversity' => array( 'Wikiversity' => NS_PROJECT ),
	'+wikipedia' => array( 'Wikipedia' => NS_PROJECT ),
	'+wiktionary' => array( 'Wiktionary' => NS_PROJECT ),
	'+wikivoyage' => array(
		'Wikivoyage' => NS_PROJECT,
		'WV' => NS_PROJECT,
	),

Maybe that list needs a bit of cleaning. Please comment.

Event Timeline

Your analysis is correct. You can clean that without issue, that will be help to facilitate readability.

Test procedure will be straightforward and trivial: once the change is merged, you can check one per one if the alias are still working.

Thanks for your review, @Dereckson. I can work in a patch for this, as it'll be easy, but it's not on my priority list right now so it might take a while before I submit a patch for this. I think Low priority (as it's right now) or even lowest is the most appropriate status of this task.

Okay. About priority, lowest for a cleaning task escaping only narrowly the definition of technical debt would be a little too low. AFAIK, it escapes the definition, as we don't depend of the cleaning to be able to amend properly the configuration.

Dereckson renamed this task from Redundant wgNamespacesAliases? to Remove redundant entries from wgNamespacesAliases.Apr 14 2016, 1:20 PM

Change 286812 had a related patch set uploaded (by Dereckson):
Remove redundant NS_PROJECT entries from wgNamespacesAliases

https://gerrit.wikimedia.org/r/286812

Change 286812 merged by jenkins-bot:
Remove redundant NS_PROJECT entries from wgNamespacesAliases

https://gerrit.wikimedia.org/r/286812

Luke081515 moved this task from To deploy to Done on the Wikimedia-Site-requests board.
Luke081515 subscribed.

Patch was merged.