Page MenuHomePhabricator
Create Task
Maniphest T131036

[Bug] Failed to find message key "wikibase-error-ui-client-error"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

The wikibase.api.RepoApiError.tests resource loader module (in the wikibase/javascript-api component) requires this message, but no such message exists.

https://github.com/wikimedia/mediawiki-extensions-WikibaseJavaScriptApi/blob/ccf9fd234368f7a6bd2a569be14711e4c15f13a4/tests/resources.php#L39

Failed to find 'wikibase-error-ui-client-error' (it)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update JavaScript Api component to 2.0mediawiki/extensions/Wikibasemaster+1 -3
Follow up fix to HTML escaping in wikibase.api.RepoApiErrormediawiki/extensions/WikibaseJavaScriptApimaster+9 -5
Release 2.1.0mediawiki/extensions/WikibaseJavaScriptApimaster+7 -1
Remove reference to unused/non-existing messagemediawiki/extensions/WikibaseJavaScriptApimaster+0 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Mar 27 2016, 11:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2016, 11:42 PM
Krinkle updated the task description. (Show Details)Mar 27 2016, 11:42 PM
Lydia_Pintscher added a subscriber: JanZerebecki.Mar 28 2016, 9:54 AM
JanZerebecki updated the task description. (Show Details)Mar 28 2016, 11:19 AM
JanZerebecki added subscribers: • Jonas, thiemowmde.
Lydia_Pintscher renamed this task from Failed to find message key "wikibase-error-ui-client-error" to [Bug] Failed to find message key "wikibase-error-ui-client-error".Apr 3 2016, 11:38 AM
Lydia_Pintscher triaged this task as Low priority.
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.
Krinkle unsubscribed.Apr 8 2016, 12:09 AM
• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Jul 20 2016, 1:45 AM
Krinkle added a parent task: T129976: Provide a structural unit test to confirm each module message exists.Jul 28 2016, 8:29 PM
Krinkle updated the task description. (Show Details)
Krinkle updated the task description. (Show Details)
Krinkle added a comment.Jul 28 2016, 8:32 PM

This is now blocking T129976. See https://gerrit.wikimedia.org/r/#/c/277457/

1) ResourcesTest::testMissingMessages
   Message 'wikibase-error-ui-client-error' required by 'wikibase.api.RepoApiError.tests' must exist
   Failed asserting that false is true.
Lydia_Pintscher added a project: Wikidata-Sprint-2016-08-02.Jul 28 2016, 8:35 PM
gerritbot subscribed.Jul 29 2016, 2:19 AM

Change 301736 had a related patch set uploaded (by Aude):
Remove reference to unused/non-existing message

https://gerrit.wikimedia.org/r/301736

• Jonas closed this task as Resolved.Jul 29 2016, 1:09 PM
• Jonas added a project: Wikidata-Sprint-2016-07-19.
• Jonas moved this task from Proposed to Done on the Wikidata-Sprint-2016-07-19 board.
gerritbot added a comment.Jul 29 2016, 1:18 PM

Change 301736 merged by jenkins-bot:
Remove reference to unused/non-existing message

https://gerrit.wikimedia.org/r/301736

hoo moved this task from Proposed to Done on the Wikidata-Sprint-2016-08-02 board.Jul 31 2016, 10:47 AM
Lydia_Pintscher moved this task from ready to go to in progress on the Wikidata board.Aug 2 2016, 8:59 AM
Lydia_Pintscher removed a project: Wikidata-Sprint-2016-08-02.Aug 2 2016, 9:09 AM
Krinkle reopened this task as Open.EditedAug 3 2016, 6:23 AM

It seems this wasn't pulled-through in the nightly build.

It's still there in the Wikidata extension:

https://github.com/wikimedia/mediawiki-extensions-Wikidata/blob/b9514fb4f579609e9157cac5ebd8510d42be776b/vendor/wikibase/javascript-api/tests/resources.php#L39

It looks like this is pulled in from a composer package, not via any of the embedded MediaWiki extensions.

Latest version at https://packagist.org/packages/wikibase/javascript-api is v2.0.0 from 2016-05-31. I guess a new version needs to be tagged?

Also, even then, in extensions/Wikibase/composer.json it is installing "wikibase/javascript-api": "~1.1", which isn't even the latest version. Looks like that needs to be bumped as well.

Lydia_Pintscher added a project: Wikidata-Sprint-2016-08-02.Aug 3 2016, 8:07 AM
Lydia_Pintscher moved this task from Done to Backlog on the Wikidata-Sprint-2016-08-02 board.Aug 3 2016, 8:09 AM
gerritbot added a comment.Aug 3 2016, 10:53 AM

Change 302684 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Update JavaScript Api component to 2.0

https://gerrit.wikimedia.org/r/302684

gerritbot added a comment.Aug 3 2016, 10:59 AM

Change 302687 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Release 2.1.0

https://gerrit.wikimedia.org/r/302687

gerritbot added a comment.Aug 3 2016, 5:44 PM

Change 302687 merged by jenkins-bot:
Release 2.1.0

https://gerrit.wikimedia.org/r/302687

gerritbot added a comment.Aug 4 2016, 9:09 AM

Change 302890 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Follow up fix to HTML escaping in wikibase.api.RepoApiError

https://gerrit.wikimedia.org/r/302890

gerritbot added a comment.Aug 4 2016, 10:13 AM

Change 302890 merged by jenkins-bot:
Follow up fix to HTML escaping in wikibase.api.RepoApiError

https://gerrit.wikimedia.org/r/302890

• Jonas moved this task from Backlog to Review on the Wikidata-Sprint-2016-08-02 board.Aug 4 2016, 1:30 PM
• Jonas closed this task as Resolved.Aug 5 2016, 10:19 AM
• Jonas reopened this task as Open.
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-08-02 board.
• Jonas moved this task from Done to Review on the Wikidata-Sprint-2016-08-02 board.
Krinkle added a comment.Aug 8 2016, 9:01 PM
In T131036#2518549, @gerritbot wrote:

Change 302684 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Update JavaScript Api component to 2.0

https://gerrit.wikimedia.org/r/302684

Still waiting for this one to land, and then get pulled through from Wikibase to Wikidata.

thiemowmde claimed this task.Aug 9 2016, 7:53 AM
thiemowmde added projects: Patch-For-Review, MediaWiki-extensions-Wikibase-Client.
• adrianheine unsubscribed.Aug 9 2016, 9:12 AM
• Jonas closed this task as Resolved.Aug 9 2016, 10:11 AM
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-08-02 board.
gerritbot added a comment.Aug 9 2016, 2:50 PM

Change 302684 merged by jenkins-bot:
Update JavaScript Api component to 2.0

https://gerrit.wikimedia.org/r/302684

Reedy removed a project: Patch-For-Review.May 17 2019, 9:48 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits