Page MenuHomePhabricator
Create Task
Maniphest T131050

Tagline is pushing the page actions to the next line
Closed, ResolvedPublic
Actions

Description

Visit https://en.m.wikipedia.org/wiki/Sun?mobileaction=beta on a tablet-size screen and you'll see that the page actions are not on the same line as the title. This is different from the mocks at https://phabricator.wikimedia.org/T128350

Details

SubjectRepoBranchLines +/-
Beta: Vertically align the page actions with the titlemediawiki/extensions/MobileFrontendmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bmansurov created this task.Mar 28 2016, 12:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2016, 12:30 PM
Jdlrobson assigned this task to • Nirzar.Mar 29 2016, 5:09 PM
Jdlrobson added a project: Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay.
Jdlrobson subscribed.

What do you think Nirzar?

Jdlrobson triaged this task as Medium priority.Mar 30 2016, 5:09 PM
Jdlrobson added a parent task: T127250: Prepare Wikidata descriptions to roll out to stable.
• Nirzar added a comment.Mar 31 2016, 10:42 PM

It would be nice to have article actions in same line as the title of the article. vertically center aligned.

align.png (319×1 px, 127 KB)

• Nirzar reassigned this task from • Nirzar to • bmansurov.Mar 31 2016, 10:42 PM
• Nirzar subscribed.
• bmansurov removed • bmansurov as the assignee of this task.Apr 1 2016, 11:40 AM
• bmansurov moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.

I've pulled this into todo since we have an input from Nirzar now.

• bmansurov claimed this task.Apr 1 2016, 4:22 PM
• bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.
gerritbot subscribed.Apr 1 2016, 4:37 PM

Change 280943 had a related patch set uploaded (by Bmansurov):
Beta: Vertically align the page actions with the title

https://gerrit.wikimedia.org/r/280943

gerritbot added a project: Patch-For-Review.Apr 1 2016, 4:37 PM
• bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.Apr 1 2016, 4:37 PM
phuedx moved this task from Code Review to Done on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.Apr 4 2016, 9:52 AM
phuedx moved this task from Done to Ready for Signoff on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.
gerritbot added a comment.Apr 4 2016, 10:01 AM

Change 280943 merged by jenkins-bot:
Beta: Vertically align the page actions with the title

https://gerrit.wikimedia.org/r/280943

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)).Apr 4 2016, 11:00 AM
• bmansurov removed • bmansurov as the assignee of this task.Apr 4 2016, 12:11 PM
• bmansurov removed a project: Patch-For-Review.Apr 5 2016, 8:12 PM
Jdlrobson added a comment.Apr 6 2016, 4:43 PM

@Nirzar can you sign this off please?:
http://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?mobileaction=beta
Looks great to me.

dr0ptp4kt assigned this task to • bmansurov.Apr 7 2016, 5:07 PM
dr0ptp4kt reassigned this task from • bmansurov to • Nirzar.
• Nirzar added a comment.Apr 8 2016, 4:43 PM

Looks good!

Jdlrobson closed this task as Resolved.Apr 8 2016, 5:02 PM
• Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.Apr 11 2016, 10:45 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL