Page MenuHomePhabricator

Notification panel layout not recalculated when expanding/collapsing cross-wiki notification bundle
Closed, ResolvedPublic

Description

Given a cross-wiki notification bundle with enough notifications to make it taller than the current viewport, once it is expanded it pushed the panel footer out of the viewport:

cx-notif-expanded-no-footer.png (731×1 px, 323 KB)

The panel footer is expected to become sticky, which happens only once you start scrolling after expanding the bundle.

In addition, if you did some scrolling and collapse the bundle again, the panel won't readjust its size, keeping some gap between the notifications and the footer:

cx-wiki-panel-gap.png (731×1 px, 284 KB)

These are some edge cases which probably require very specific number of notifications, so may not be the most urgent thing, but since I encountered them I wanted to capture those.

Event Timeline

Change 283094 had a related patch set uploaded (by Catrope):
ClippableElement: Gracefully handle failure to call clip() after natural height change

https://gerrit.wikimedia.org/r/283094

Change 283094 merged by jenkins-bot:
ClippableElement: Gracefully handle failure to call clip() after natural height change

https://gerrit.wikimedia.org/r/283094

Catrope claimed this task.