Page MenuHomePhabricator

Fix display of page banners in Minerva
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/r/#/c/279687/

This greatly improves our mobile support by doing various things,
including:

  • Hide the image until it's positioned to avoid jerking movements
  • Take into consideration whether a position was provided or not
  • For portrait photos (height is greater than container) reposition

to -10% on basis that most portraits put the face in this position

  • Add a bottom transparent border for white lead banners
  • Add a panorama class to distinguish between portrait photos and panoramas

in the styling

  • Reposition panoramas at -25% when no center position given

Event Timeline

Jdlrobson renamed this task from Fix display of page images in Minerva to Fix display of page banners in Minerva .Mar 28 2016, 6:09 PM
Jdlrobson edited projects, added Wikidata-Page-Banner; removed MobileFrontend.

Change 279687 had a related patch set uploaded (by Jdlrobson):
Optimise for automatic page images banners on moile views

https://gerrit.wikimedia.org/r/279687

Change 279687 merged by jenkins-bot:
Optimise for automatic page images banners on mobile views

https://gerrit.wikimedia.org/r/279687

Change 280327 had a related patch set uploaded (by Jdlrobson):
Optimise for automatic page images banners on mobile views

https://gerrit.wikimedia.org/r/280327

Change 280328 had a related patch set uploaded (by Jdlrobson):
Optimise for automatic page images banners on mobile views

https://gerrit.wikimedia.org/r/280328

Change 280328 merged by jenkins-bot:
Optimise for automatic page images banners on mobile views

https://gerrit.wikimedia.org/r/280328

Change 280327 merged by jenkins-bot:
Optimise for automatic page images banners on mobile views

https://gerrit.wikimedia.org/r/280327