Page MenuHomePhabricator

Create a checkuser entry for global rename requests
Open, HighPublic

Description

Currently global rename requests aren't logged by checkuser while they might be exploited in various fashions for abusing.

Event Timeline

Vituzzu created this task.Mar 29 2016, 10:25 PM
Restricted Application added subscribers: JEumerus, Steinsplitter, Aklapper. · View Herald Transcript

We can probably do this in a similar manner to how AbuseFilter does it...

Special:GlobalRenameRequest can be used from any wiki, and feeds into the queue on meta. Should the CU entries be logged on the wiki where the user made the request? Or should it be logged to a central wiki (metawiki)?

And should the CU logs be updated during the rename? Or should they forever point to the username that made the request?

MarcoAurelio added a comment.EditedApr 17 2016, 9:19 AM

Special:GlobalRenameRequest can be used from any wiki, and feeds into the queue on meta. Should the CU entries be logged on the wiki where the user made the request? Or should it be logged to a central wiki (metawiki)?

I'd say that, if possible, should log to both.

And should the CU logs be updated during the rename?

IMHO yes, to allow better searching in the CU-log instead of having to
remember if this or that user were once renamed.

In order to counter increased abuse of this feature, I'd ask for some eyes in this task if at all possible. Thank you.

Luke081515 triaged this task as High priority.Nov 12 2016, 10:45 AM
Huji added a subscriber: Huji.Dec 19 2016, 12:23 AM

And should the CU logs be updated during the rename?

IMHO yes, to allow better searching in the CU-log instead of having to
remember if this or that user were once renamed.

I am afraid this is not currently possible, until T145265 is resolved.

@Huji Can at least the first part (creating a CU log entry) be actioned? Thanks.

TBolliger moved this task from Untriaged to Backlog on the Anti-Harassment board.Mar 9 2018, 1:59 PM
MarcoAurelio awarded a token.

Ping @Huji wrt T131207#3558482 - thanks! :)

1997kB added a subscriber: 1997kB.Jun 12 2018, 2:16 AM

Per T131207#2164035, it looks like this is how AF does it:

if ( ExtensionRegistry::getInstance()->isLoaded( 'CheckUser' )
      && strpos( $wgAbuseFilterNotifications, 'rc' ) === false
) {
      $rc = $entry->getRecentChange();
      CheckUserHooks::updateCheckUserData( $rc );
}

I'm guessing the relevant place to do something similar in CA is probably in GlobalRenameUser.php around here, since there's a ManualLogEntry there where we could call getRecentChange() as the rename was processed. Or at least this seems the simplest way to do the CU logging piece without getting more advanced as discussed in T131207#2212568.