Page MenuHomePhabricator

Create a checkuser entry for global rename requests
Open, Needs TriagePublic

Description

Currently global rename requests aren't logged by checkuser while they might be exploited in various fashions for abusing.

Event Timeline

We can probably do this in a similar manner to how AbuseFilter does it...

Special:GlobalRenameRequest can be used from any wiki, and feeds into the queue on meta. Should the CU entries be logged on the wiki where the user made the request? Or should it be logged to a central wiki (metawiki)?

And should the CU logs be updated during the rename? Or should they forever point to the username that made the request?

Special:GlobalRenameRequest can be used from any wiki, and feeds into the queue on meta. Should the CU entries be logged on the wiki where the user made the request? Or should it be logged to a central wiki (metawiki)?

I'd say that, if possible, should log to both.

And should the CU logs be updated during the rename?

IMHO yes, to allow better searching in the CU-log instead of having to
remember if this or that user were once renamed.

In order to counter increased abuse of this feature, I'd ask for some eyes in this task if at all possible. Thank you.

And should the CU logs be updated during the rename?

IMHO yes, to allow better searching in the CU-log instead of having to
remember if this or that user were once renamed.

I am afraid this is not currently possible, until T145265 is resolved.

@Huji Can at least the first part (creating a CU log entry) be actioned? Thanks.

Per T131207#2164035, it looks like this is how AF does it:

if ( ExtensionRegistry::getInstance()->isLoaded( 'CheckUser' )
      && strpos( $wgAbuseFilterNotifications, 'rc' ) === false
) {
      $rc = $entry->getRecentChange();
      CheckUserHooks::updateCheckUserData( $rc );
}

I'm guessing the relevant place to do something similar in CA is probably in GlobalRenameUser.php around here, since there's a ManualLogEntry there where we could call [[ https://gerrit.wikimedia.org/g/mediawiki/core/+/2f127bb114f73951c14887710aec34c87de132ba/includes/logging/ManualLogEntry.php#326 | getRecentChange() ]] as the rename was processed. Or at least this seems the simplest way to do the CU logging piece without getting more advanced as discussed in T131207#2212568.

Huji raised the priority of this task from High to Needs Triage.Jun 15 2020, 10:58 PM

The task is not claimed and priority was set several years ago. Unprioritizing.

Niharika added a subscriber: Niharika.

This was brought to my attention by @drochford. Anti-Harassment Tools can do a technical investigation into this ticket in the next few weeks. Sorry, I can't be more specific around timelines - there is a fair amount of SecurePoll work on the team at the moment.
Noting that this ticket is for adding an entry to the CU database for global renames. There will need to be follow-up tasks for displaying these entries, unless that can be achieved automatically.