[Epic] Consolidate queue abstractions
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	awight
	Mar 30 2016, 6:44 PM

Referenced Files

None

Subscribers

Aklapper

Ejegg

gerritbot

Description

We currently have Queue, PHP-Queue, and DonationQueue abstractions for our PHP code. Push towards consolidating, probably towards an isolated module like PHP-Queue. DonationQueue is sort of legit because it wraps PHP-Queue, maybe rename so that the class's responsibilities are more clear, it's just a message normalization helper. Maybe push that functionality into a new thing.

Drop KeyValue store.

The generalized queue functionality is the responsibility of PHP-Queue. Any configuration or financial extensions should be implemented in SmashPig.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Integrate with PHP-Queue	wikimedia/fundraising/SmashPig	master	+356 -2
	New interface for atomic reads	wikimedia/fundraising/php-queue	master	+151 -6

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		None	T117466 Q3 GOALS! (January-March) Keep at top of Q3 column
Resolved		None	T108229 [Epic] SPOF: Replace ActiveMQ donation queues with a more robust software stack
Resolved		None	T133108 [Epic] Rewrite all queue clients to use a single shim library, improve library
Resolved		None	T131271 [Epic] Consolidate queue abstractions
Resolved		awight	T133964 Implement AtomicReadBuffer for choice of PHP-Queue backend
Resolved	Spike	None	T130304 Spike: Choose a new backend for queueing
Resolved		Ejegg	T133965 Write high-level SmashPig DonationQueue

Event Timeline

awight created this task.Mar 30 2016, 6:44 PM

• DStrine moved this task from Triage to Next on the Fundraising-Backlog board.Mar 30 2016, 8:17 PM

awight added a parent task: T133108: [Epic] Rewrite all queue clients to use a single shim library, improve library.Apr 19 2016, 9:19 PM

awight removed a parent task: T108229: [Epic] SPOF: Replace ActiveMQ donation queues with a more robust software stack.

awight updated the task description. (Show Details)Apr 20 2016, 8:49 PM

awight set the point value for this task to 3.

Change 284597 had a related patch set uploaded (by Awight):
[WIP] Integrate with PHP-Queue

https://gerrit.wikimedia.org/r/284597

gerritbot added a project: Patch-For-Review.Apr 20 2016, 9:44 PM

awight claimed this task.Apr 21 2016, 12:58 AM

awight merged a task: T129386: Create SmashPig PhpQueueDataStore compatible with StompDataStore.

awight added a project: Fundraising Sprint Hermit Crab Husbandry.

awight moved this task from Backlog to Doing on the Fundraising Sprint Hermit Crab Husbandry board.

awight added a subscriber: Ejegg.

• DStrine moved this task from Next to Current Sprint & Completed in Q4 1516 on the Fundraising-Backlog board.Apr 22 2016, 3:50 PM

Change 284977 had a related patch set uploaded (by Awight):
[WIP] Playing with the FIFO API

https://gerrit.wikimedia.org/r/284977

I've created a generic wrapper in SmashPig, FifoDataStore, which can use any FIFO PHP-Queue backend. I'll build the donation message specific layer on top of that.

awight moved this task from Doing to Review on the Fundraising Sprint Hermit Crab Husbandry board.Apr 25 2016, 9:00 PM

• DStrine added a project: Fundraising Sprint Internet Exploring.Apr 27 2016, 10:25 PM

awight moved this task from Backlog to Review on the Fundraising Sprint Internet Exploring board.Apr 27 2016, 10:50 PM

awight renamed this task from Consolidate queue abstractions to [Epic] Consolidate queue abstractions.Apr 29 2016, 12:35 AM

awight added a project: Technical-Debt.

awight removed the point value 3 for this task.

awight created subtask T133964: Implement AtomicReadBuffer for choice of PHP-Queue backend .Apr 29 2016, 12:38 AM

awight created subtask T133965: Write high-level SmashPig DonationQueue.Apr 29 2016, 12:46 AM

Change 284977 merged by jenkins-bot:
New interface for atomic reads

https://gerrit.wikimedia.org/r/284977

Danny_B added a project: Epic.May 6 2016, 7:47 PM

• DStrine added a project: Fundraising Sprint Jabberwock Slaying.May 11 2016, 10:22 PM