Page MenuHomePhabricator

Beta: unneeded horizontal lines on non-JS browsers
Closed, ResolvedPublic

Description

On a non-JS browser when a page is not available in another language, and when non-JS editing is disabled, you'll see a page similar to this one:

Expected: Two horizontal lines below the title should also be removed.

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masterHide page actions for non-JS browsers when no actions are visible

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2016, 7:26 PM

Change 281551 had a related patch set uploaded (by Bmansurov):
Beta: Hide page actions for non-JS browsers when no actions are visible

https://gerrit.wikimedia.org/r/281551

Change 281551 merged by jenkins-bot:
Hide page actions for non-JS browsers when no actions are visible

https://gerrit.wikimedia.org/r/281551

This comment was removed by Jdlrobson.

Is there a URL for testing this?

It seems like it's still showing. After disabling Javascript in Firefox and visiting http://reading-web-staging.wmflabs.org/wiki/Nolang?mobileaction=beta&useformat=mobile I see the following.

Ditto with Opera Mini.

Sorry, forgot to update the code in the server. Try clearing the browser data, it should work now.

phuedx assigned this task to dr0ptp4kt.Apr 8 2016, 8:45 AM
phuedx added a subscriber: phuedx.

Over to you @dr0ptp4kt.

P.S. I <3 autocomplete…