Page MenuHomePhabricator

Check that vendor matches composer.lock during fundraising_code_update
Closed, DeclinedPublic2 Estimated Story Points

Description

We should make sure we don't forget to update vendor submodules before deploying things. fr_code_update should complain or bomb out when any composer.lock exists in the tree and doesn't match what's in the corresponding vendor folder.

Event Timeline

DStrine set the point value for this task to 2.Apr 11 2016, 8:23 PM
DStrine subscribed.

Rolling this into Frig would be nice, cos then we'd have better tools. But that means that Frig has to do the basic stuff correctly as well.

Is this as simple as diffing composer.lock with the one that's in vendor?

FWIW I have been using Frig to deploy and it seems to work well for the basic stuff, what problems have you?

Is this as simple as diffing composer.lock with the one that's in vendor?

Oh, snaps! This one? vendor/composer/installed.json Seems to need some parsing to get a proper diff...

FWIW I have been using Frig to deploy and it seems to work well for the basic stuff, what problems have you?

Only lack of training, and fear of change!

I agree this is a good idea, but it should happen during development/integration, and before merge into the deployment branch on gerrit.