Cursoring off of focused block nodes with shift behaves unexpectedly
Open, HighPublic8 Story Points


To reproduce:

  1. create a document with this HTML: <p>Foo</p><figure class="ve-align-right"><img src="" width="100" height="50" alt="Example"><figcaption>caption</figcaption></figure><p>Bar</p>
  2. Click the image to focus it.
  3. Hold down the shift key and use the arrow keys to move the caret focus.

Expected result: The selection expands in the direction in which you moved the cursor.

Actual result: Depends on the direction moved. Left/up just moves the caret without expanding the selection. Right/down selects the interior of the focused node.

DLynch created this task.Mar 31 2016, 3:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2016, 3:30 PM

Change 280680 had a related patch set uploaded (by DLynch):
[Failing] Test cases for cursoring off focused block nodes with shift

Interestingly, shift+right off of the block node actually removes the blockImage+imageCaption from the data model, which I didn't really expect a call to setLinearSelection to be capable of.

Jdforrester-WMF triaged this task as High priority.Apr 1 2016, 10:11 AM
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF moved this task from To Triage to TR3: Language support on the VisualEditor board.

In a brief test, this seems to work fine now…

(Nevermind, the unit tests still fail.)