Page MenuHomePhabricator
Create Task
Maniphest T131499

Upgrade all cache clusters to Varnish 4
Closed, ResolvedPublic
Actions

Description

The maps cache cluster has been upgraded to Varnish 4: https://phabricator.wikimedia.org/T122880.

We need to upgrade misc, upload and text.

Details

ProjectBranchLines +/-Subject
operations/puppetproduction+141 -609cache: get rid of varnish 3 compatibility code
operations/puppetproduction+16 -1Add 'varnish_version' salt grain
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 DuplicateNoneT109331 Deleted files sometimes remain visible to non-privileged users if permanently linked
 DuplicateNoneT133819 upload-lb.ulsfo.wikimedia.org still allow access to some deleted files
 OpenNoneT124286 [Epic] Wikidata language support
 OpenNoneT134592 Allow setting the UI to a language other than English for anonymous users
 DuplicateNikerabbitT149419 Interface language selection for unregistered users on Wikimedia projects
 InvalidNoneT114662 RFC: Per-language URLs for multilingual wiki pages
 DuplicateBBlackT119038 Image cache issue when 'over-writing' an image on commons
 ResolvedemaT133821 Make CDN purges reliable
 OpenNoneT108580 HTTPS for internal service traffic
 InvalidNoneT109325 Outbound HTTPS for varnish backend instances
 OpenNoneT122867 Evaluate the feasibility of cache invalidation for the action API
 ResolvedemaT122881 Install XKey vmod
 DeclinedNoneT142841 Sideways Only-If-Cached on misses at a primary DC
 ResolvedemaT131499 Upgrade all cache clusters to Varnish 4
 ResolvedemaT126206 Upgrade to Varnish 4: things to remember
 ResolvedemaT128788 Port varnishlog.py to new VSL API
 ResolvedemaT131353 Port remaining scripts depending on varnishlog.py to new VSL API
ResolvedemaT131501 Convert misc cluster to Varnish 4
 ResolvedemaT134989 WDQS empty response - transfer clsoed with 15042 bytes remaining to read
 ResolvedemaT131502 Convert upload cluster to Varnish 4
 ResolvedBBlackT131761 Solve large-object/stream/pass/chunked in upload cluster better
 ResolvedemaT142076 Analyze Range requests on cache_upload frontend
 ResolvedemaT142233 Varnish 4 stalls with two consecutive Range requests using HTTP persistent connections
 ResolvedemaT131503 Convert text cluster to Varnish 4
 ResolvedBBlackT135696 Sort out vcl_deliver vs vcl_synth mess with v4 VCL
 ResolvedemaT150660 Post Varnish 4 migration cleanup

Event Timeline

ema created this task.Apr 1 2016, 1:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2016, 1:56 PM
ema triaged this task as Medium priority.Apr 1 2016, 1:56 PM
ema added a subtask: T126206: Upgrade to Varnish 4: things to remember.
ema added a subtask: T131353: Port remaining scripts depending on varnishlog.py to new VSL API .
ema added a subtask: T122881: Install XKey vmod.
ema created subtask T131501: Convert misc cluster to Varnish 4.Apr 1 2016, 2:00 PM
ema created subtask T131502: Convert upload cluster to Varnish 4.
ema created subtask T131503: Convert text cluster to Varnish 4.
ema claimed this task.Apr 1 2016, 2:03 PM
ema removed a subtask: T122881: Install XKey vmod.
ema added a parent task: T122867: Evaluate the feasibility of cache invalidation for the action API.Apr 1 2016, 2:05 PM
ema added a parent task: T122881: Install XKey vmod.
ema added a parent task: T114662: RFC: Per-language URLs for multilingual wiki pages.
ema renamed this task from Uprade all cache clusters to Varnish 4 to Upgrade all cache clusters to Varnish 4.Apr 4 2016, 4:27 PM
JanZerebecki added a subscriber: JanZerebecki.Apr 10 2016, 9:02 PM
BBlack added a parent task: T109325: Outbound HTTPS for varnish backend instances.May 4 2016, 4:36 PM
MZMcBride added a subscriber: MZMcBride.May 9 2016, 2:28 PM
ema closed subtask T131501: Convert misc cluster to Varnish 4 as Resolved.May 11 2016, 12:55 PM
BBlack reopened subtask T131501: Convert misc cluster to Varnish 4 as Open.May 13 2016, 9:12 PM
BBlack created subtask T135696: Sort out vcl_deliver vs vcl_synth mess with v4 VCL.May 19 2016, 12:22 AM
ema closed subtask T131501: Convert misc cluster to Varnish 4 as Resolved.May 24 2016, 9:31 AM
BBlack closed subtask T135696: Sort out vcl_deliver vs vcl_synth mess with v4 VCL as Resolved.May 31 2016, 9:30 PM
gerritbot added a subscriber: gerritbot.Jun 8 2016, 12:17 PM

Change 293296 had a related patch set uploaded (by Ema):
Add 'varnish_version' salt grain

https://gerrit.wikimedia.org/r/293296

gerritbot added a project: Patch-For-Review.Jun 8 2016, 12:17 PM
gerritbot added a comment.Jun 8 2016, 12:35 PM

Change 293296 merged by Ema:
Add 'varnish_version' salt grain

https://gerrit.wikimedia.org/r/293296

ema mentioned this in rOPUP025143a517eb: Add 'varnish_version' salt grain.Jun 8 2016, 12:39 PM
ema mentioned this in rOPUP5c97ade4f8db: Add 'varnish_version' salt grain.Jun 17 2016, 6:06 PM
BBlack added a comment.Jun 20 2016, 4:18 PM

One of the goals for this quarter (Q4 2015-16) was to more-fully evaluate the difficulties for converting cache_text and cache_upload, and decide which we'd like to tackle next. The summary output of those evaluations is:

  • cache_text unique difficulties
    • Several applayer backends that may differ on behaviors for compatibility (MW/hhvm, restbase, cxserver, citoid)
    • In general, traffic is much more general-case: lots of distinct kinds of cacheability, conditional responses, etc.
    • geoip support - requires updating/writing new C-in-VCL or evaluating existing geoip2 vmods or writing a new one
    • Analytics here is much more important than any other cluster, and so far we've seen a pattern that our varnish4 analytics issues have an ongoing long-tail of bugfixing that's not complete yet.
  • cache_upload:
    • One backend to deal with for now (swift), with one kind of cacheability behavior.
    • Support for large objects in combination with streaming and Range is a somewhat unique problem to solve, but it seems likely varnish4 supports these things much better than varnish3 did in general. Some minor open questions about whether all of our old patched/plus functionality on these matters exists in varnish4, but again seems likely.

On the balance of these things, we selected cache_upload as the next target, to complete conversion during Q1 2016-17.

BBlack added a subtask: T142841: Sideways Only-If-Cached on misses at a primary DC.Aug 12 2016, 2:39 PM
BBlack removed a subtask: T142841: Sideways Only-If-Cached on misses at a primary DC.
BBlack added a parent task: T142841: Sideways Only-If-Cached on misses at a primary DC.
ema moved this task from Triage to Varnish v4 on the Traffic board.Sep 30 2016, 2:45 PM
BBlack closed subtask T131502: Convert upload cluster to Varnish 4 as Resolved.Oct 10 2016, 1:55 PM
ema closed subtask T131353: Port remaining scripts depending on varnishlog.py to new VSL API as Resolved.Oct 21 2016, 9:39 AM
ema created subtask T150660: Post Varnish 4 migration cleanup.Nov 14 2016, 4:07 PM
gerritbot added a comment.Nov 18 2016, 11:58 AM

Change 322252 had a related patch set uploaded (by Ema):
cache: get rid of varnish 3 compatibility code

https://gerrit.wikimedia.org/r/322252

gerritbot added a comment.Nov 21 2016, 2:34 PM

Change 322252 merged by Ema:
cache: get rid of varnish 3 compatibility code

https://gerrit.wikimedia.org/r/322252

ema closed subtask T150660: Post Varnish 4 migration cleanup as Resolved.Nov 24 2016, 3:04 PM
ema closed this task as Resolved.Nov 24 2016, 3:06 PM
ema closed subtask T131503: Convert text cluster to Varnish 4 as Resolved.
BBlack closed subtask T126206: Upgrade to Varnish 4: things to remember as Resolved.Apr 18 2017, 6:27 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL