There are quiet a few PHP files in there ; we should php -l them at CI.
Description
Description
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | JeanFred | T131714 Hold a Wiki Loves Monuments coding sprint at Wikimedia Hackathon 2016 | |||
| Resolved | JeanFred | T131597 Add PHP linting to labs/tools/heritage |
Event Timeline
Comment Actions
Change 281129 had a related patch set uploaded (by Jean-Frédéric):
Add jsonlint and phplint as experimental pipeline to labs/tools/heritage
Comment Actions
Change 281129 merged by jenkins-bot:
Add jsonlint and phplint as experimental pipeline to labs/tools/heritage
Comment Actions
Change 281330 had a related patch set uploaded (by Jean-Frédéric):
Add jsonlint and php55lint pipelines for heritage
Comment Actions
Change 281330 merged by jenkins-bot:
Add jsonlint and php55lint pipelines for heritage
Comment Actions
Merci @hashar :)
I could not check this as there are no reviews opened right now but it should be fine − I’ll just close this and reopen in case of problem.
Comment Actions
You can comment in Gerrit recheck on a change that has been merged. That will run the tests and report back :-}
Comment Actions
Right! Tested on https://gerrit.wikimedia.org/r/#/c/281280/ − looks fine.
The jsonlint is not executed though (it was not either in experimental). OTOh we do not have JSON files yet (we are planning to) so it might be related ?