JS ComboBoxInputWidget should support autocompletion by non-prefix searches as well
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Glaisher
	Apr 2 2016, 4:37 PM

Description

@Florian pointed out in https://gerrit.wikimedia.org/r/#/c/280693/2/SpecialSearchWiki.php that it only supports autocompletion by the prefix. For example, if there is an option with display name "Foobar", it should show that option even if you typed "bar".
In Firefox/Ubuntu locally, when JS is disabled, the native form element does support this.

Details

	Subject	Repo	Branch	Lines +/-
	ComboBoxInputWidget: Allow filtering by input	oojs/ui	master	+52 -4

Customize query in gerrit

Related Objects

Mentioned Here: rGOJU4bb33dbb8515: SelectWidget: Rewrite getItemMatcher without regular expressions
rGOJU63111dc734bd: MenuSelectWidget: Add 'filterMode'

Event Timeline

Glaisher created this task.Apr 2 2016, 4:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2016, 4:37 PM

Change 281259 had a related patch set uploaded (by Florianschmidtwelzow):
Allow to filter ComboboxInputWidget by input

https://gerrit.wikimedia.org/r/281259

gerritbot added a project: Patch-For-Review.Apr 3 2016, 8:13 AM

Florian claimed this task.Apr 3 2016, 8:13 AM

Florian moved this task from Backlog to Doing on the OOUI board.Apr 3 2016, 11:51 AM

Jdforrester-WMF moved this task from Doing to OOjs-UI-0.17.0 on the OOUI board.Apr 20 2016, 12:44 AM

Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.0); removed OOUI.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 20 2016, 12:44 AM

Jdforrester-WMF triaged this task as Medium priority.Apr 20 2016, 12:44 AM

Jdforrester-WMF moved this task from OOjs-UI-0.17.0 to Reviewing on the OOUI board.Apr 26 2016, 9:51 PM

Jdforrester-WMF edited projects, added OOUI; removed OOUI (OOjs-UI-0.17.0).

Change 281259 abandoned by Florianschmidtwelzow:
ComboBoxInputWidget: Allow filtering by input

https://gerrit.wikimedia.org/r/281259

• Prtksxna removed a project: Patch-For-Review.Jul 26 2017, 9:18 AM

• Prtksxna subscribed.

As I don't see anybody working on this in near future, I will move it to Backlog. Correct, @Prtksxna or @matmarex?

Volker_E moved this task from Reviewing to Backlog on the OOUI board.Jun 4 2018, 2:56 PM

OK.

matmarex unsubscribed.Jun 4 2018, 3:56 PM

Change 281259 restored by Prtksxna:
ComboBoxInputWidget: Allow filtering by input

Reason:
Rebasing and testing.

https://gerrit.wikimedia.org/r/281259

I was just looking at @Florian's patch and I don't think there are any issues with it, I suppose it just got lost in review queues.

Sorry to ping you after you've unsubscribed, but @matmarex, @Anomie, could you please take a quick look at this again? I have rebased it.

Volker_E added a project: Patch-For-Review.Jun 7 2018, 9:59 AM

Volker_E moved this task from Backlog to Doing on the OOUI board.

This might have also been fixed by rGOJU63111dc734bd: MenuSelectWidget: Add 'filterMode' + rGOJU4bb33dbb8515: SelectWidget: Rewrite getItemMatcher without regular expressions?

You can now do something like this:

					new OO.ui.ComboBoxInputWidget( {
						options: [
							…
						],
						menu: {
							filterFromInput: true,
							filterMode: 'substring'
						}
					} ),

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Jun 30 2020, 10:12 AM

TerraCodes unsubscribed.Jul 1 2020, 4:42 AM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:02 PM

Florian removed Florian as the assignee of this task.Nov 26 2020, 6:16 PM

Florian removed a project: Patch-Needs-Improvement.

Change 281259 abandoned by Florianschmidtwelzow:
[oojs/ui@master] ComboBoxInputWidget: Allow filtering by input

Reason:

https://gerrit.wikimedia.org/r/281259