Page MenuHomePhabricator
Create Task
Maniphest T131633

ApiVisualEditorEdit sets DerivativeRequest into global context
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The DerivativeRequest introduced in rEVED581d1350e6ba: When saving, return the full contentSub to the client is set into the global context. This alters the global context destructively which effects ApiAction logging and APIAfterExecute hooks. In the case of ApiAction logging, it results in logging that the api action performed was 'view' rather than the expected 'visualeditoredit'.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+9 -2Restore original WebRequest after we're finished messing with FlaggedRevs on save
Customize query in gerrit

Related Objects

Event Timeline

bd808 created this task.Apr 2 2016, 6:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2016, 6:03 PM
Jdforrester-WMF triaged this task as High priority.Apr 3 2016, 8:01 AM
Jdforrester-WMF lowered the priority of this task from High to Medium.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF set the point value for this task to 1.
• AlexMonk-WMF added a subscriber: • AlexMonk-WMF.Apr 15 2016, 9:46 PM

On the VE side we could restore the original WebRequest after we're done with FlaggedRevs. Would that be enough @bd808?

bd808 added a comment.Apr 15 2016, 10:29 PM
In T131633#2211421, @AlexMonk-WMF wrote:

On the VE side we could restore the original WebRequest after we're done with FlaggedRevs. Would that be enough @bd808?

Yeah that should work.

• AlexMonk-WMF claimed this task.Apr 16 2016, 12:06 PM

Let's just do that then

gerritbot added a subscriber: gerritbot.Apr 16 2016, 12:26 PM

Change 283768 had a related patch set uploaded (by Alex Monk):
Restore original WebRequest after we're finished messing with FlaggedRevs on save

https://gerrit.wikimedia.org/r/283768

gerritbot added a comment.Apr 18 2016, 7:54 AM

Change 283768 merged by jenkins-bot:
Restore original WebRequest after we're finished messing with FlaggedRevs on save

https://gerrit.wikimedia.org/r/283768

• AlexMonk-WMF closed this task as Resolved.Apr 18 2016, 2:30 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL