Cross-wiki upload tool errors display as raw JSON rather than a notice (in production)
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Quiddity
	Apr 3 2016, 12:48 PM

Description

I was trying to upload a file with an existing filename (to test the user-warning message).
The warning template is broken.

Unknown warning: "{"upload":{"result":"Warning","warnings":{"exists-normalized":"Pixies-Doolittle.png"},"filekey":"13x9lgznmpi4.6u1hq5.3099303.jpg","sessionkey":"13x9l

Screenshot-Editing User:Quiddity (WMF)-sandbox - Wikipedia - Mozilla Firefox-3.png (743×1 px, 193 KB)

Additionally, I checked against a filename that is protected ("example"), and a filename that was previously deleted ("screenshot"), and those are both also broken.

Screenshot-Editing User:Quiddity (WMF)-sandbox - Wikipedia - Mozilla Firefox-1.png (743×1 px, 174 KB)

Screenshot-Editing User:Quiddity (WMF)-sandbox - Wikipedia - Mozilla Firefox-4.png (743×1 px, 178 KB)

(Firefox, Ubuntu. Tested at https://en.wikipedia.org/wiki/User:Quiddity_%28WMF%29/sandbox )

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	mw.Upload.BookletLayout: Handle additional warnings/errors	mediawiki/core	master	+21 -3

Customize query in gerrit

Event Timeline

Quiddity created this task.Apr 3 2016, 12:48 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptApr 3 2016, 12:48 PM

Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald Transcript

Jdforrester-WMF renamed this task from Upload wizard warning templates are broken to [Regression] Cross-wiki upload tool errors are broken in production.Apr 3 2016, 12:51 PM

Jdforrester-WMF triaged this task as Unbreak Now! priority.

Jdforrester-WMF removed a project: UploadWizard.

Jdforrester-WMF added subscribers: MarkTraceur, matmarex.

Restricted Application added a subscriber: Matanya. · View Herald TranscriptApr 3 2016, 12:51 PM

Define "broken"? I suppose they should have better error messages, and I think they used so, so that's possibly a regression. But it's mostly intentional that you can't upload new versions of previously existing files.

matmarex added a project: MediaWiki-Uploading.Apr 3 2016, 12:57 PM

Jdforrester-WMF renamed this task from [Regression] Cross-wiki upload tool errors are broken in production to [Regression] Cross-wiki upload tool errors display as raw JSON rather than a notice (in production).Apr 3 2016, 12:59 PM

This is not a regression, we just don't have any handling for these warnings ('exists-normalized' and 'was-deleted'), nor for the 'protectedpage' error. We have handling for 'exists' and 'duplicate-archive', which is what you should get most of the time.

Change 281741 had a related patch set uploaded (by Bartosz Dziewoński):
mw.Upload.BookletLayout: Handle additional warnings/errors

https://gerrit.wikimedia.org/r/281741

gerritbot added a project: Patch-For-Review.Apr 5 2016, 8:26 PM

matmarex claimed this task.Apr 5 2016, 8:29 PM

Change 281741 merged by jenkins-bot:
mw.Upload.BookletLayout: Handle additional warnings/errors

https://gerrit.wikimedia.org/r/281741

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-04-12_(1.27.0-wmf.21)), MW-1.27-release-notes.Apr 6 2016, 6:00 AM

matmarex closed this task as Resolved.Apr 6 2016, 11:34 AM

matmarex removed a project: Patch-For-Review.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Apr 8 2016, 4:43 PM

Jdforrester-WMF set the point value for this task to 8.May 10 2016, 1:23 AM

	F3822419: Screenshot-Editing User:Quiddity (WMF)-sandbox - Wikipedia - Mozilla Firefox-1.png
	Apr 3 2016, 12:48 PM

	F3822420: Screenshot-Editing User:Quiddity (WMF)-sandbox - Wikipedia - Mozilla Firefox-3.png
	Apr 3 2016, 12:48 PM

	F3822417: Screenshot-Editing User:Quiddity (WMF)-sandbox - Wikipedia - Mozilla Firefox-4.png
	Apr 3 2016, 12:48 PM

Cross-wiki upload tool errors display as raw JSON rather than a notice (in production)Closed, ResolvedPublic8 Estimated Story PointsActions

Description

Details

Event Timeline

Cross-wiki upload tool errors display as raw JSON rather than a notice (in production)
Closed, ResolvedPublic8 Estimated Story Points
Actions