I can't see the bottom of the date text-area in the upload wizard in visual editor, it is cut-off by the bottom of the screen. (Firefox, Ubuntu). Changing the window size doesn't fix it.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Prevent modal windows from exceeding available height on Firefox | oojs/ui | master | +44 -0 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 281718 had a related patch set uploaded (by Bartosz Dziewoński):
Prevent modal windows from exceeding available height on Firefox
Comment Actions
I was thinking of T122238, and this is indeed related. I don't think we can blame Firefox in this case, our CSS is (like I said on that task) still definitely messed up. We're defining the height of the dialog in three different ways (top+bottom, height and max-height) and expecting the browser to come up with something sane.
- Firefox decides to ignore the bottom: 1em constraint, keeping top: 1em and max-height: 100%, which results in a dialog taller than available window height, with the bottom cut off.
- Other browsers I tested decide to ignore both top: 1em and bottom: 1em, which results in a dialog that takes the whole available window height and touches the top and bottom edge.
I don't really want to rewrite how we set dialog sizes (which would probably be a breaking change for some unorthodox uses on dialogs in VE), and it seems we can work around this by setting max-height: calc(100% - 2em);, which is what we really want (to take the whole available window height, minus 1em spacing at top and bottom). calc() is not supported everywhere, so the other browsers will still see max-height: 100% and hopefully do something reasonable.
| Before, Firefox | |
| Before, other browsers | |
| After |
Comment Actions
Change 281718 merged by jenkins-bot:
Prevent modal windows from exceeding available height on Firefox