Adding @20after4 and @greg and @mmodell

We will need to upload a patch to https://phabricator.wikimedia.org/diffusion/ARC/ or create an arcanist/windows repo so I can include a fix for arcanist running on windows please.

Ugh, http://www.jrsoftware.org/files/is/license.txt is a weird combo of 3 clause BSD and zlib licenses :/

@greg yep, but it shoulden cause license issues for us since we are not including the whole programme just using it to generate the file that it can then create the installer.

Yeah, mostly just an aside from a license geek :) Nothing in there restricts what you can do with generated binaries, afaict.

@greg ive included php in the installer. Should I remove it or keep it. It use php 7 x64 and x86. And is optional meaning the user has to select the php option to install it.

@greg Ive updated the installer to 1.1.2 and now includes VC14 redistributable setup files from Microsoft since those are needed when installing php. I'm not sure if that affects the review you did you of license since there redistributable files which allows you to redistribute them.

@Paladox: You need to check the exact license of included files and mention the exact license of included files here. This is not work to be done by others (except for when you have specific questions). :)

@Aklapper according to https://www.microsoft.com/en-gb/download/details.aspx?id=48145 it doesn't show a license.

If there is no information I'm afraid you will have to contact Microsoft to find out yourself, so you yourself will be on the safe side, legally speaking.

In T131939#2202663, @Paladox wrote:

@Aklapper according to https://www.microsoft.com/en-gb/download/details.aspx?id=48145 it doesn't show a license.

https://msdn.microsoft.com/en-us/library/ms235299.aspx

Oh thanks for finding that @Reedy and @Aklapper looks like I can legally use the redist files, since I'm using the vc_redist files which it says I can.

So, I'm trying to figure out the next steps for this task and one of the questions that we need to answer is "What is this task actually asking to be done?"

Options:

1. "Recommend" (ie: we put "The recommended way is..." in the documentation) the use of this installer for all Windows users to interact with WMF's Differential?
2. Offer it as an unsupported third-party option for Windows users (iow: The recommended way for us is what upstream Phabricator recommends, but we'd link to this unsupported option).

Option 1 implies a certain level of support by... someone. Not WMF RelEng as we have no way of testing this ourselves.

I've updated the task title (and a little bit of the description) to reflect this.

In T131939#2291067, @greg wrote:

So, I'm trying to figure out the next steps for this task and one of the questions that we need to answer is "What is this task actually asking to be done?"

Options:

1. "Recommend" (ie: we put "The recommended way is..." in the documentation) the use of this installer for all Windows users to interact with WMF's Differential?
2. Offer it as an unsupported third-party option for Windows users (iow: The recommended way for us is what upstream Phabricator recommends, but we'd link to this unsupported option).

Option 1 implies a certain level of support by... someone. Not WMF RelEng as we have no way of testing this ourselves.

I've updated the task title (and a little bit of the description) to reflect this.

I spoke with @mmodell on irc and he says that I can continue maintaining it. I would like it to be option one since doing this makes it so easy for windows users to interact with differential on Wikimedia. Any one can upload a pull request to improve it.

I want to be very clear about what "recommend" could mean in this context. A recommendation on the Differential wiki page would seem to imply a level of support and maintainability and responsiveness (all aspects of "support" I guess). I personally don't want to add a third-party something just because it's easier if it doesn't have a commitment of support.

I'd like to get some others to comment on the ease and effectiveness and completeness of this installer and then we can make a decision. (Sorry if this seems arduous, just RelEng can't test this easily so we need others to verify for us)

In T131939#2291272, @greg wrote:

I want to be very clear about what "recommend" could mean in this context. A recommendation on the Differential wiki page would seem to imply a level of support and maintainability and responsiveness (all aspects of "support" I guess). I personally don't want to add a third-party something just because it's easier if it doesn't have a commitment of support.

I'd like to get some others to comment on the ease and effectiveness and completeness of this installer and then we can make a decision. (Sorry if this seems arduous, just RelEng can't test this easily so we need others to verify for us)

Ok.

@greg @Luke081515 has been using the installer and found some bugs that I fixed in it that upstream refusing to think are bugs in arc in windows.

Actually I can confirm, that this installer is useful for users, he installs arc and php for you, so you only have to use it ;). I used it, and it works.

I created a mac installer today for arcanist + libphutil :)

https://github.com/paladox/Arcanist-installer-for-mac

What is actually being proposed in this task?
Adding two lines "Unofficial Arcanist installers for Microsoft Windows and Mac OS are available here. Use them at your own risk." to some wiki page? Which page? Or something else? The task summary talks about "documenting" and the task description does not. The task description talks about "importing" (from where?) while the task summary does not.

Well what i created this task for is to discuss importing Arcanist for windows installer which i created into a wikimedia repo. And also the same for the mac.

But for now we could add to the arcanist setup page we have on mediawiki to describe these unofficially installation methods.

It would make it easy for users to install these un official installers also it's open source so users can build there own or install the ones i built for the release.

Mac users can just use the same setup as Linux users: https://www.mediawiki.org/wiki/Phabricator/Arcanist#Using_git_.28recommended.29

@greg Hi, Windows users can do the same except from they need to add it to the path by going through the control panel or exporting it through the command line. The installer I created does all this so all the user has to do is go through the installer and then it is all installed. It adds it to path too.

If we are going to go with option #1 (offically supporting it), shouldn't we move it into the WMF org on github or host it here on phab?

I think we should go with "Offer it as an unsupported third-party option for Windows users" since it looks like the WMF has no plans of officially supporting this?

As far as I know WMF has no capacity to officially support this currently.