Page MenuHomePhabricator
Create Task
Maniphest T131972

Regression: TemplateData editor should not add "format" parameter on save
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When editing existing templatedata without the (optional) format property, running it through the editor results in "format": null being added to the blob which is unexpected.

Details

SubjectRepoBranchLines +/-
GUI: Don't set format: null when outputting datamediawiki/extensions/TemplateDatamaster+7 -5
Customize query in gerrit

Event Timeline

Krinkle created this task.Apr 6 2016, 7:27 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 6 2016, 7:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle renamed this task from Regression: TemplateData editor adds dirty optional parameter on save to Regression: TemplateData editor should not add "format" parameter on save.Apr 6 2016, 7:28 PM
gerritbot subscribed.Apr 6 2016, 10:24 PM

Change 282075 had a related patch set uploaded (by Alex Monk):
GUI: Don't set format: null when outputting data

https://gerrit.wikimedia.org/r/282075

gerritbot added a project: Patch-For-Review.Apr 6 2016, 10:24 PM
• AlexMonk-WMF claimed this task.Apr 6 2016, 10:24 PM
Jdforrester-WMF closed this task as Resolved.Apr 8 2016, 4:22 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
gerritbot added a comment.Apr 8 2016, 4:24 PM

Change 282075 merged by jenkins-bot:
GUI: Don't set format: null when outputting data

https://gerrit.wikimedia.org/r/282075

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Apr 8 2016, 4:46 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-12_(1.27.0-wmf.21)).Apr 8 2016, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL