Page MenuHomePhabricator

Multiple images not handled properly
Closed, ResolvedPublic


When there are multiple (best) values with the ArticlePlaceholderImageProperty property, ArticlePlaceholder mangles them together instead of properly showing multiple images or selecting one.

The code in question is in topImageRenderer in mw.ext.articlePlaceholder.entityRenderer.lua.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Maybe it should use pageimages to determine the image to show? We have already sorted out all the properties and order of them for pageimages.

Change 282955 had a related patch set uploaded (by Lucie Kaffee):
Only output the first value for the image property

Would also be neat to have the images not displayed as main image as statements!

Lucie moved this task from Review to Done on the ArticlePlaceholder board.

Change 282955 merged by jenkins-bot:
Only output the first value for the image property