Page MenuHomePhabricator
Create Task
Maniphest T1321

browsertests-VisualEditor-language-screenshot jenkins job failing
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

At the moment, we have a couple of jenkins jobs:

The first job runs local firefox and fails randomly.

Options:

  • check if any of the headless environment variables helps
  • check if any of the reuse browser environment variables helps
  • check if switching to local chromium helps

The second job run a remote browser on sauce labs, but it does not support Chinese and Japanese fonts (at least), but only on linux host.

  • check if running the job on windows (or mac) helps.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Created job for VisualEditor screenshots that runs using Sauce Labsintegration/configmaster+6 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Nov 18 2014, 4:17 PM
zeljkofilipin claimed this task.
zeljkofilipin raised the priority of this task from to Medium.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added a project: Release-Engineering-Team.
zeljkofilipin changed Security from none to None.
zeljkofilipin added a subscriber: Amire80.
zeljkofilipin added subscribers: dduvall, hashar.Nov 18 2014, 5:44 PM
hashar added a comment.Nov 18 2014, 5:48 PM

Can you confirm you have mediawiki_selenium 0.4.1 +

And:

export HEADLESS_DESTROY_AT_EXIT=false

See https://bugzilla.wikimedia.org/show_bug.cgi?id=71602#c6

zeljkofilipin added a comment.Nov 20 2014, 9:43 AM

Related commit: https://gerrit.wikimedia.org/r/#/c/174660/

zeljkofilipin added a comment.Nov 20 2014, 9:52 AM
In T1321#23186, @hashar wrote:

Can you confirm you have mediawiki_selenium 0.4.1 +

Yes.

00:03:37.335 Installing mediawiki_selenium 0.4.1
00:03:37.335 0:  mediawiki_selenium (0.4.1) from /mnt/jenkins-workspace/workspace/browsertests-VisualEditor-language-screenshot-windows_8.1-firefox/LANGUAGE_SCREENSHOT_CODE/ar/label/gems/2.0.0/specifications/mediawiki_selenium-0.4.1.gemspec

From:

https://integration.wikimedia.org/ci/view/BrowserTests/view/VisualEditor/job/browsertests-VisualEditor-language-screenshot-windows_8.1-firefox/LANGUAGE_SCREENSHOT_CODE=ar,label=contintLabsSlave%20&&%20UbuntuTrusty/1/console

hashar added a comment.Nov 20 2014, 10:33 AM

The job has BROWSER=firefox and HEADLESS=false, I am not sure what happens exactly in some case. We probably want to set HEADLESS=true and set HEADLESS* env variables to avoid killing the XVFB.

The relevant code for 0.4.1 is:

http://git.wikimedia.org/blob/mediawiki%2Fselenium/0.4.1/lib%2Fmediawiki_selenium%2Fsupport%2Fhooks.rb#L27

See also the README.md doc under "Headless mode" section: http://git.wikimedia.org/blob/mediawiki%2Fselenium/0.4.1/README.md

I think we want:

HEADLESS=true
HEADLESS_DESTROY_AT_EXIT=false

That will default to use display 99, we have an XVFB listening on 99 already.

If we want the headless gem to spawn a new xvfb on a different display port, we can use HEADLESS_REUSE=false which will make it spawn a new xvfb on a different display port. But that is probably not needed.

hashar mentioned this in T1074: unable to obtain stable firefox connection in 60 seconds.Nov 20 2014, 10:38 AM

Some more context:

Already reported as bug 71602 - mediawiki_selenium always use the same default xvfb display 99, which explains how our jobs ends up killing each other XVFB (typical race condition).

Dan fixed it with https://gerrit.wikimedia.org/r/#/c/164704/ ( b6af34a40e ) which is included in mediawiki_selenium 0.4.1.

The jobs need to be bumped to that library version and use the appropriate env variables as described above.

zeljkofilipin raised the priority of this task from Medium to High.Nov 20 2014, 2:48 PM
Liuxinyu970226 subscribed.Nov 21 2014, 12:05 AM
zeljkofilipin removed zeljkofilipin as the assignee of this task.Dec 3 2014, 1:05 PM
zeljkofilipin lowered the priority of this task from High to Lowest.Dec 3 2014, 1:35 PM
hashar moved this task from INBOX to Backlog (ARCHIVED) on the Release-Engineering-Team board.Dec 3 2014, 2:49 PM
hashar mentioned this in T73602: mediawiki_selenium always use the same default xvfb display 99.
zeljkofilipin moved this task from Backlog (ARCHIVED) to INBOX on the Release-Engineering-Team board.Dec 12 2014, 11:51 AM
zeljkofilipin mentioned this in rCICF90ba03411f3c: Created job for VisualEditor screenshots that runs using Sauce Labs.Dec 31 2014, 6:27 PM
Amire80 closed this task as Resolved.Feb 24 2015, 9:19 AM
Amire80 assigned this task to zeljkofilipin.
Amire80 raised the priority of this task from Lowest to Medium.
Amire80 added projects: Browser-test-bug, VisualEditor.

It was moved to run on Mac, and now runs successfully.

Liuxinyu970226 unsubscribed.Feb 24 2015, 9:19 AM
greg moved this task from INBOX to Done on the Release-Engineering-Team board.Feb 24 2015, 11:35 PM
Jdforrester-WMF moved this task from To Triage to FY 18-19 Q3/Q4 on the VisualEditor board.Apr 1 2015, 4:14 PM
Jdforrester-WMF edited a custom field.Aug 4 2015, 10:32 PM
greg edited projects, added: Browser-Tests-Infrastructure; removed: Release-Engineering-Team.Aug 4 2015, 10:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits