One condition consumed from the limit for every function parameter and every level of parentheses
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Apr 8 2016, 4:16 PM

Description

Functions calls consume one condition from the limit for every function parameter. This is obviously wrong, and it means that e.g. contains_any(foo, 'a', 'b', 'c') is more expensive than 'a' in foo | 'b' in foo | 'c' in foo, even though it's faster.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/AbuseFilter	master	+33 -3	Improve how the number of conditions is counted

Customize query in gerrit

Related Objects

Mentioned In: T132048: Change $wgAbuseFilterConditionLimit for wikimedia commons

Event Timeline

matmarex created this task.Apr 8 2016, 4:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2016, 4:16 PM

matmarex added a subtask: T132189: Restore display of number of conditions used by filter on the filter's page, gated by new config variable $wgAbuseFilterProfile.Apr 8 2016, 4:17 PM

I've since learned that this has gotten painstakingly documented at https://www.mediawiki.org/wiki/Extension:AbuseFilter/Conditions. I'll archive the page and document the new simpler rules later.

matmarex renamed this task from Functions calls consume one condition from the limit for every function parameter to Functions calls consume one condition from the limit for every function parameter and every level of parentheses.Apr 9 2016, 12:45 PM

matmarex removed a subtask: T132189: Restore display of number of conditions used by filter on the filter's page, gated by new config variable $wgAbuseFilterProfile.Apr 9 2016, 12:58 PM

Dalba added a subscriber: Dalba.Apr 9 2016, 1:34 PM

Change 282477 had a related patch set uploaded (by Bartosz Dziewoński):
Improve how the number of conditions is counted

https://gerrit.wikimedia.org/r/282477

gerritbot added a project: Patch-For-Review.Apr 9 2016, 2:18 PM

matmarex triaged this task as High priority.Apr 9 2016, 2:26 PM

Change 282477 merged by jenkins-bot:
Improve how the number of conditions is counted

https://gerrit.wikimedia.org/r/282477

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-12_(1.27.0-wmf.21)).Apr 11 2016, 8:00 PM

Documented the changes: https://www.mediawiki.org/w/index.php?title=Extension%3AAbuseFilter%2FConditions&type=revision&diff=2097370&oldid=2074689

He7d3r awarded a token.Apr 12 2016, 6:39 PM

He7d3r added a subscriber: He7d3r.

matmarex renamed this task from Functions calls consume one condition from the limit for every function parameter and every level of parentheses to One condition consumed from the limit for every function parameter and every level of parentheses.Apr 16 2016, 9:08 PM

matmarex removed a project: Patch-For-Review.

matmarex mentioned this in T132048: Change $wgAbuseFilterConditionLimit for wikimedia commons.Apr 16 2016, 9:48 PM

One condition consumed from the limit for every function parameter and every level of parenthesesClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

One condition consumed from the limit for every function parameter and every level of parentheses
Closed, ResolvedPublic
Actions