Page MenuHomePhabricator
Create Task
Maniphest T132199

Beta: reduce the space between title and tagline (wikidata description)
Closed, ResolvedPublic
Actions

Description

On mobile web, we have wikidata descriptor below the title. the space between the descriptor and title should be less than what it is and the font size should be tad bit larger. 0.85em

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+2 -2Beta: fix tagline appearance
Customize query in gerrit

Related Objects

Event Timeline

• Nirzar created this task.Apr 8 2016, 6:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2016, 6:07 PM
gerritbot added a subscriber: gerritbot.Apr 8 2016, 6:07 PM

Change 282402 had a related patch set uploaded (by Bmansurov):
Beta: fix tagline appearance

https://gerrit.wikimedia.org/r/282402

gerritbot added a project: Patch-For-Review.Apr 8 2016, 6:07 PM
dr0ptp4kt moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.Apr 11 2016, 5:23 PM
dr0ptp4kt edited projects, added Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters; removed Reading-Web-Sprint-70-Lady-and-the-Trumps.Apr 11 2016, 6:03 PM
bmansurov moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.Apr 11 2016, 10:42 PM
bmansurov renamed this task from Title and tagline space to Beta: reduce the space between title and tagline (wikidata description).Apr 12 2016, 5:13 PM
bmansurov triaged this task as Low priority.
• Nirzar added a subscriber: Jdlrobson.Apr 20 2016, 5:12 PM

@Jdlrobson It's just the space between title and subtitle. it was 10px by whoever put it in with lack of spec probably, want to make it tighter to 7px. it's just a visual design fix.

Jdlrobson edited projects, added Reading-Web-Sprint-70-Lady-and-the-Trumps, Unplanned-Sprint-Work; removed Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters.Apr 20 2016, 8:00 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.
Jdlrobson removed a project: Patch-For-Review.
gerritbot added a comment.Apr 20 2016, 8:09 PM

Change 282402 merged by jenkins-bot:
Beta: fix tagline appearance

https://gerrit.wikimedia.org/r/282402

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)).Apr 20 2016, 9:00 PM
bmansurov removed bmansurov as the assignee of this task.Apr 20 2016, 10:32 PM
Jdlrobson added a comment.Apr 21 2016, 1:23 PM

@Nirzar can you sign this off on beta labs? http://en.m.wikipedia.beta.wmflabs.org/wiki/Albert Einstein (Remember to test different resolutions!)

• Nirzar added a comment.Apr 21 2016, 5:05 PM

@Jdlrobson checked on chrome desktop, safari + chrome on mobile and also non-retina device.

Looks good! signed off from design.

bmansurov closed this task as Resolved.Apr 21 2016, 5:21 PM
bmansurov claimed this task.
bmansurov removed bmansurov as the assignee of this task.
bmansurov moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.
bmansurov mentioned this in T127250: Prepare Wikidata descriptions to roll out to stable.Apr 22 2016, 9:01 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL