Page MenuHomePhabricator

Blocking with an invalid value (like "20:30") results in a (still valid) block that expires on "1 January 1970"
Closed, DuplicatePublic

Description

Not sure if this is a dup of T132212 (and therefore due to the fix for T130441), but when blocking a user on enwiki/testwiki with a date of "20:30", the resultant block entry is:

(change visibility) 20:19, 8 April 2016 LFaraone (talk | contribs | block) blocked 192.0.2.16 (talk) with an expiration time of 20:30, 1 January 1970 (anonymous users only) (test; validating an assumption) (unblock | change block)

And despite that being "in the past" (shortly after the unix epoch), the UI shows:

192.0.2.16 is already blocked. Do you want to change the settings?

Event Timeline

lfaraone created this task.Apr 8 2016, 8:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2016, 8:31 PM

A block time of "20:30" is parsed against the current day, so the block expired today at 20:30 (UTC) and that way the user would still be blocked when revisit Special:Block. When now looking at Special:Block the message would not be there.

The block log problem looks like T48798