Page MenuHomePhabricator

confusing warning about nowiki, offering details but showing none
Closed, ResolvedPublic

Description

During translation, an error message cropped up warning me about nowiki in mainspace. I did not insert any. When I clicked the "show details" button, nothing further was shown (but it showed the "hide details" button).

CX_nowiki_bug.png (572×1 px, 154 KB)

Event Timeline

Thanks for the report. A little meta-comment: Please tag Content Translation bugs as ContentTranslation and not as ContentTranslation-CXserver so that they will be easier to find.

This filter that you are seeing is only for tagging and maintenance (which I do), but it's not for blocking “bad edits”. There probably is a <nowiki> there, auto-inserted by Parsoid, but telling it to the user this way is not really useful. (Fun fact: I once suggested telling this to the user [in a more helpful way] in T117964, and @Jdforrester-WMF declined it, and here in CX we implemented almost the same thing by accident.)

Long story short, we shouldn't show any warnings in Content Translation for AbuseFilters that don't actually block publishing. Showing people suggestions that would improve edits is an important area to explore, but not this way. If it's possible to ignore filters that don't publishing, we must do it.

Amire80 triaged this task as Medium priority.Apr 26 2016, 7:52 AM

Curiously, I cannot reproduce it, although I'm pretty sure that we haven't changed anything in CX's AbuseFilter handling since this bug was opened on April 9.

I tried reproducing by translating an article from Russian to the main space in Hebrew and typing a template. The revision that I created was marked by AbuseFilter with the nowiki tag, as expected, but I didn't see a warning in the CX interface.

@santhosh, @Nikerabbit, any ideas?

We have many exceptions which cause the warning not to show and which make testing hard: the section needs to be at least 100 chars long and only checked on every 10th edit.

Might also be browser specific.

The fix for the parent task is going to be deployed this week.