Page MenuHomePhabricator

Puppet fails on all Precise execution nodes
Closed, ResolvedPublic

Description

90e56fa1ad9d3033b248cba1357751f72ab83e38 made Trusty or Jessie a requirement for mediawiki::packages::fonts which is included by toollabs::exec_environ; thus Puppet fails on all Precise hosts:

scfc@tools-exec-1205:~$ sudo puppet agent -t
Info: Retrieving plugin
Info: Loading facts in /var/lib/puppet/lib/facter/puppet_vardir.rb
Info: Loading facts in /var/lib/puppet/lib/facter/physicalcorecount.rb
Info: Loading facts in /var/lib/puppet/lib/facter/labsprojectfrommetadata.rb
Info: Loading facts in /var/lib/puppet/lib/facter/ganeti.rb
Info: Loading facts in /var/lib/puppet/lib/facter/puppet_config_dir.rb
Info: Loading facts in /var/lib/puppet/lib/facter/lldp.rb
Info: Loading facts in /var/lib/puppet/lib/facter/initsystem.rb
Info: Loading facts in /var/lib/puppet/lib/facter/root_home.rb
Info: Loading facts in /var/lib/puppet/lib/facter/pe_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/apt.rb
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: OS ubuntu >= trusty || Debian >= jessie required. at /etc/puppet/modules/mediawiki/manifests/packages/fonts.pp:6 on node tools-exec-1205.tools.eqiad.wmflabs
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run
scfc@tools-exec-1205:~$

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The mediawiki doesn't support precise anymore, as multiple parts of it are now HHVM and trusty and newer only.

Why do we run precise in tools? do we really need mediawiki classes there?

Change 282958 had a related patch set uploaded (by Yuvipanda):
tools: Do not install fonts on precise instances

https://gerrit.wikimedia.org/r/282958

@Joe T94790 is the tracking ticket for getting rid of precise from tools. Unfortunately that's going to be a long hard slog, but I'm picking it up again to make some more progress on it.

I'm just going to remove the fonts from precise. The reason the fonts were included was to ensure consistent environment for anything doing font rendering, so that they'd end up being similar to renderings from production. But since production isn't really trusty at all anymore that makes no sense.

Change 282958 merged by Yuvipanda:
tools: Don't track mediawiki's font list for precise

https://gerrit.wikimedia.org/r/282958

Change 283121 had a related patch set uploaded (by Yuvipanda):
tools: Remove non-precise fonts from precise hosts

https://gerrit.wikimedia.org/r/283121

Change 283121 merged by Yuvipanda:
tools: Remove non-precise fonts from precise hosts

https://gerrit.wikimedia.org/r/283121

yuvipanda claimed this task.

Fixed! I made a legacy class with the fonts that are still available in precise, and used the mediawiki one for trusty.