Page MenuHomePhabricator
Create Task
Maniphest T132338

MT dropdown shows JS functions
Closed, ResolvedPublic
Actions

Description

Originally reported from Romanian Wikipedia, but could be the case elsewhere too.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Guard against Array.prototype modifications in MT controlmediawiki/extensions/ContentTranslationmaster+4 -0
Customize query in gerrit

Event Timeline

Arrbee created this task.Apr 11 2016, 2:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2016, 2:34 PM
Arrbee triaged this task as High priority.Apr 11 2016, 2:34 PM
KartikMistry subscribed.Apr 11 2016, 3:17 PM

Seems working fine for me:

Screen Shot 2016-04-11 at 8.45.59 PM.png (372×588 px, 35 KB)

Nikerabbit subscribed.Apr 12 2016, 8:16 AM

I guess we are using foreach ( var foo in array ) without guard and the user is using a script that extends array prototype (discouraged behavior nowdays).

gerritbot subscribed.Apr 12 2016, 8:20 AM

Change 282864 had a related patch set uploaded (by Nikerabbit):
Guard against Array.prototype modifications in MT control

https://gerrit.wikimedia.org/r/282864

gerritbot added a project: Patch-For-Review.Apr 12 2016, 8:20 AM
Nikerabbit claimed this task.Apr 12 2016, 8:22 AM
Nikerabbit added a project: Language-Q4-2016-Sprint 1.
Nikerabbit moved this task from Backlog to In Review on the Language-Q4-2016-Sprint 1 board.
santhosh moved this task from In Review to QA on the Language-Q4-2016-Sprint 1 board.Apr 12 2016, 11:03 AM
gerritbot added a comment.Apr 12 2016, 11:12 AM

Change 282864 merged by jenkins-bot:
Guard against Array.prototype modifications in MT control

https://gerrit.wikimedia.org/r/282864

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-12_(1.27.0-wmf.21)).Apr 12 2016, 12:00 PM
Amire80 moved this task from Needs Triage to CX9 candidates on the ContentTranslation board.Apr 13 2016, 4:55 PM
Amire80 added a project: ContentTranslation-Release9.Apr 13 2016, 5:26 PM
Arrbee moved this task from QA to Done on the Language-Q4-2016-Sprint 1 board.Apr 19 2016, 4:49 AM
Restricted Application added a project: Language-Engineering April-June 2016. · View Herald TranscriptApr 19 2016, 4:49 AM
Amire80 closed this task as Resolved.Apr 20 2016, 9:55 AM
Amire80 moved this task from Backlog to High-priority Bugs on the ContentTranslation-Release9 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits