Page MenuHomePhabricator

Check for MySQL storage engines during installation doesn't check whether engine is actually available
Closed, ResolvedPublic

Description

Author: janrei.g

Description:
Improve storage engine check

During installation MediaWiki checks the result of the MySQL query "SHOW ENGINES" whether the selected engine is listed in the "Engine" column. However, this query returns all engines MySQL knows about no matter whether they are actually available. It is necessary to check the "Support" column as well, only if it contains "YES" or "DEFAULT" the corresponding engine is supported.

I have attached a patch to add this check.


Version: 1.16.x
Severity: minor

Attached:

Details

Reference
bz11242

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:53 PM
bzimport set Reference to bz11242.
demon added a comment.Jul 1 2009, 1:23 PM

Assigning to me, can commit this later today.

demon added a comment.Jul 2 2009, 1:00 AM

Done in r52672