Page MenuHomePhabricator

Get support for xhprof_frame_begin & xhprof_frame_end functions added to XHProf PECL package
Closed, DeclinedPublic

Description

Issue filed upstream at https://github.com/phacility/xhprof/issues/51

This would make finishing the implementation of a pure xhprof profiler for MediaWiki fairly trivial.

Related Objects

Event Timeline

• bd808 raised the priority of this task from to Needs Triage.
• bd808 updated the task description. (Show Details)
• bd808 added a project: Librarization.
• bd808 changed Security from none to None.
• bd808 subscribed.

During the most recent discussion of the Profiling RFC, Tim and others asked that we find a way to retain the ability to support sub-function level profiling. One idea that came up was to look into implementing this as a feature of the XHProf library. Upon investigation it was found that the HHVM implementation already has this functionality. This just leaves a need to see the feature backported to the PECL XHProf implementation.

• bd808 triaged this task as Medium priority.Nov 18 2014, 9:23 PM

No longer a blocker for T759: xhprof for MW as @aaron has implemented a pure PHP solution after finding bugs in the HHVM implementation.

• bd808 changed the task status from Open to Stalled.Dec 11 2014, 1:24 AM

Pull request is languishing upstream.

• bd808 lowered the priority of this task from Medium to Low.Dec 15 2014, 8:19 PM
• bd808 added a subscriber: epriestley.

Upstream pull request has sat without a comment since 2014-11-28. At this point it looks like @epriestley and Phacility aren't interested continuing active development of XHProf.