Page MenuHomePhabricator
Create Task
Maniphest T132538

isConfiguredProxy not recognizing $wgSquidServers with port
Open, Needs TriagePublic
Actions

Description

When $wgSquidServers is configured with port, isConfiguredProxy will not recognize the server and thus the X-Forwarded-For field is not trusted.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+62 -6Make IP.php trust X-Forwarded-For supplied by $wgSquidServers with port
Customize query in gerrit

Related Objects

Event Timeline

Nbdd0121 created this task.Apr 13 2016, 1:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2016, 1:15 AM
gerritbot added a subscriber: gerritbot.Apr 13 2016, 1:21 AM

Change 283115 had a related patch set uploaded (by Nbdd0121):
Make IP.php trust X-Forwarded-For supplied by $wgSquidServers with port

https://gerrit.wikimedia.org/r/283115

gerritbot added a project: Patch-For-Review.Apr 13 2016, 1:21 AM
Platonides added a subscriber: Platonides.May 22 2016, 11:01 PM

What about repeating them (without port) in $wgSquidServersNoPurge?

Nbdd0121 added a comment.May 22 2016, 11:06 PM
In T132538#2316800, @Platonides wrote:

What about repeating them (without port) in $wgSquidServersNoPurge?

Do you mean appending these to $wgSquidServersNoPurge automatically in Setup.php?

Aklapper removed Nbdd0121 as the assignee of this task.Apr 13 2020, 11:25 AM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.

@Nbdd0121: I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

Justin_C_Lloyd added a subscriber: Justin_C_Lloyd.Dec 1 2021, 12:10 PM
Justin_C_Lloyd added a comment.Dec 1 2021, 12:13 PM

This bug is referenced by the docs for $wgCdnServers, and I'd just commented on T291768 about needed to add port 80 to my list of Varnish servers. However, the purges seem to be working whether or not I also add the IPs to $wgCdnServersNopurge. I am on MW 1.36.2, so maybe this issue was resolved with 1.36 (or even 1.35)?

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL