Create Task
Maniphest T132538

isConfiguredProxy not recognizing $wgSquidServers with port
Open, Needs TriagePublic
Actions

Description

When $wgSquidServers is configured with port, isConfiguredProxy will not recognize the server and thus the X-Forwarded-For field is not trusted.

Nbdd0121 created this task.Apr 13 2016, 1:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2016, 1:15 AM
gerritbot added a subscriber: gerritbot.Apr 13 2016, 1:21 AM

Change 283115 had a related patch set uploaded (by Nbdd0121):
Make IP.php trust X-Forwarded-For supplied by $wgSquidServers with port

https://gerrit.wikimedia.org/r/283115

Platonides added a subscriber: Platonides.May 22 2016, 11:01 PM

What about repeating them (without port) in $wgSquidServersNoPurge?

Nbdd0121 added a comment.May 22 2016, 11:06 PM
In T132538#2316800, @Platonides wrote:

What about repeating them (without port) in $wgSquidServersNoPurge?

Do you mean appending these to $wgSquidServersNoPurge automatically in Setup.php?

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL