Array representation of EntityIdValue should be based on ID serialization.
Closed, ResolvedPublic
Actions

Description

The array returned by EntityIdValue::getArrayValue should include the ID serialization in the "id" field. Inclusion of the "entity-type" and "numeric-id" fields should become optional in the future. But that is probably blocked on moving the serialization/deserialization code out of the DataValue object itself.

EntityIdValue::newFromArray should be able to construct a new EntityIdValue from the serialized value in the "id" field allone. Support for construction based on "entity-type" and "numeric-id" needs to remain possible, so old data remains readable.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Allow deserialization of new EntityIdValue serializations	mediawiki/extensions/Wikibase	master	+11 -3

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Duplicate		None	T66288 basic support for structured data on mediawiki files
Invalid		Lydia_Pintscher	T76012 make use of new entity type for multimedia / structured data of media files
Open		None	T109579 [Epic] Give more sister projects access to Wikidata
Open		None	T187900 There is no way to reference a specific quote on Wikiquote
Stalled		None	T71753 [Story] Wikibase / Wikidata support on Wikiquote
Open		None	T88728 Improve Wikimedia dumping infrastructure
Open		None	T88991 improve Wikidata dumps [tracking]
Open		None	T67626 [Epic] Support for queries on-wiki (automated list generation)
Resolved		Addshore	T76019 [Story] Support new types of Entities in Wikibase Client
Resolved		thiemowmde	T135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
Resolved		Addshore	T75496 [Epic] Support new types of Entities in Wikibase Repository
Invalid		None	T109969 Wikidata breaking API changes (tracking)
Resolved		thiemowmde	T56085 [Task] EntityIdValues should be serialized as strings, not type/number structures.
Resolved		thiemowmde	T132592 Array representation of EntityIdValue should be based on ID serialization.

Event Timeline

daniel created this task.Apr 13 2016, 3:30 PM

Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Apr 21 2016, 11:43 AM

thiemowmde moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-04-26 board.Apr 26 2016, 1:10 PM

Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-05-10.May 10 2016, 11:53 AM

Tobi_WMDE_SW moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-05-10 board.May 10 2016, 11:54 AM

Patches for review and steps to do:

https://github.com/DataValues/Serialization/pull/14 makes it possible to deserialize all kinds of new entity type IDs. RFC draft, please discuss!
https://github.com/wmde/WikibaseDataModel/pull/669 changes the serialization. RFC draft, please discuss!
https://github.com/wmde/WikibaseDataModel/pull/671 is a simpler, cleaner alternative to 669.
Make a release of both components.
Change WikibaseRepo::getDataValueDeserializer and the same in client.

thiemowmde moved this task from Review to Backlog on the Wikidata-Sprint-2016-04-26 board.May 11 2016, 2:13 PM

thiemowmde moved this task from Backlog to Review on the Wikidata-Sprint-2016-05-10 board.

Lydia_Pintscher added a project: Wikidata-Sprint-2016-05-24.May 24 2016, 12:38 PM

Addshore moved this task from Proposed to Review on the Wikidata-Sprint-2016-05-24 board.May 24 2016, 12:38 PM

Change 290656 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Allow deserialization of new EntityIdValue serializations

https://gerrit.wikimedia.org/r/290656

Change 290656 merged by jenkins-bot:
Allow deserialization of new EntityIdValue serializations

https://gerrit.wikimedia.org/r/290656

Patches still waiting for review:

Released DataValues Serialization 1.1
Wikibase Repo and Client are aware of the new id field
Option for a "sparse" mode that suppresses the legacy fields? See https://github.com/wmde/WikibaseDataModel/pull/671#issuecomment-222733497
https://github.com/wmde/WikibaseDataModel/pull/668
Release DataModel 6.1