Page MenuHomePhabricator

Array representation of EntityIdValue should be based on ID serialization.
Closed, ResolvedPublic

Description

The array returned by EntityIdValue::getArrayValue should include the ID serialization in the "id" field. Inclusion of the "entity-type" and "numeric-id" fields should become optional in the future. But that is probably blocked on moving the serialization/deserialization code out of the DataValue object itself.

EntityIdValue::newFromArray should be able to construct a new EntityIdValue from the serialized value in the "id" field allone. Support for construction based on "entity-type" and "numeric-id" needs to remain possible, so old data remains readable.

Related Objects

StatusAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
ResolvedAbit
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
DuplicateNone
InvalidLydia_Pintscher
OpenNone
OpenNone
StalledNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedthiemowmde
OpenNone
OpenNone
Resolvedthiemowmde
Resolvedthiemowmde

Event Timeline

daniel created this task.Apr 13 2016, 3:30 PM
thiemowmde moved this task from Backlog to Review on the Wikidata-Sprint-2016-04-26 board.

Patches for review and steps to do:

thiemowmde moved this task from Backlog to Review on the Wikidata-Sprint-2016-05-10 board.

Change 290656 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Allow deserialization of new EntityIdValue serializations

https://gerrit.wikimedia.org/r/290656

Change 290656 merged by jenkins-bot:
Allow deserialization of new EntityIdValue serializations

https://gerrit.wikimedia.org/r/290656

Patches still waiting for review:

thiemowmde closed this task as Resolved.Jul 20 2016, 7:58 AM
thiemowmde claimed this task.
thiemowmde moved this task from Review to Done on the Wikidata-Sprint-2016-07-19 board.