Page MenuHomePhabricator

Clean up property passing in dashiki
Closed, DeclinedPublic

Description

Dashiki reads configuration from wikis and creates visualizations from this. Until now, it kind of works like a basic functional programming environment where everything explicitly passes the necessary parameters to child components or API calls. Some stuff doesn't work that way, and all parameters are copied using the CopyParams view model. Some stuff implicitly passes parameters by just passing an object known to contain the appropriate properties.

This must be very confusing and will lead to spaghetti-fication of the code eventually. It's pretty easy to change at this point and I should do so sooner than later. This is the last known ugliness with the code. An audit to find other unknown uglinesses would be useful.

This work seems important before we rely on dashiki even more with wikistats 2.0 work.

Related Objects