Page MenuHomePhabricator

Refactor and DRY login logic and modernize to use new fetcher logic
Closed, ResolvedPublic

Description

Login logic needs to be DRYed up and brought in line with the rest of our fetcher architecture.

  • Create an Authentication Controller singleton that has high level methods for login/account creation and holds user information
  • Move logic from login / account creation VCs into the new class
  • Modernize fetchers to use Promise based API in line with the newer fetchers
  • Move auto login logic from session singleton into the new class
  • Refactor view controllers to use this new class
  • Add WMF prefixes to classes
  • Remove legacy auth code

Event Timeline

This should probably be done in conjunction with adopting the new AuthManager and SessionManager handshakes.

Fjalapeno raised the priority of this task from Medium to Needs Triage.Jun 10 2016, 4:02 PM
Fjalapeno updated the task description. (Show Details)

@JMinor didn't have time to do this when moving to the new architecture… would like to have this on the saturn board at a low priority

Its is especially a mess now with the new auth manager logic

LGoto claimed this task.