Page MenuHomePhabricator
Create Task
Maniphest T132710

References in headers are not stripped anymore for search
Closed, ResolvedPublic
Actions

Description

Cirrus Search is supposed to remove references from headings, however now it does not work anymore, witnessed by:

http://cirrustest-cirrus-browser-bot.wmflabs.org/wiki/HasHeadingsWithReference?action=cirrusDump

Details

SubjectRepoBranchLines +/-
Fix reference handlingmediawiki/extensions/CirrusSearchmaster+6 -2
Customize query in gerrit

Event Timeline

Smalyshev created this task.Apr 14 2016, 6:03 PM
Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptApr 14 2016, 6:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Smalyshev added subscribers: EBernhardson, dcausse.Apr 14 2016, 6:03 PM

Looks like this code is to blame in PageDataBuilder.php:

			$heading = preg_replace( '/<sup>\s*\[\s*\d+\s*\]\s*<\/sup>/', '', $heading );
gerritbot subscribed.Apr 14 2016, 6:19 PM

Change 283495 had a related patch set uploaded (by Smalyshev):
Use HtmlFormatter to strip tags

https://gerrit.wikimedia.org/r/283495

gerritbot added a project: Patch-For-Review.Apr 14 2016, 6:19 PM
gerritbot added a comment.Apr 14 2016, 11:57 PM

Change 283495 merged by jenkins-bot:
Fix reference handling

https://gerrit.wikimedia.org/r/283495

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)).Apr 19 2016, 11:02 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 11:02 PM
• Deskana closed this task as Resolved.Apr 21 2016, 10:13 PM
• Deskana assigned this task to Smalyshev.
• Deskana triaged this task as Medium priority.
• Deskana edited projects, added Discovery-Search (Current work); removed Discovery-Search.
• Deskana moved this task from Incoming to Needs Reporting on the Discovery-Search (Current work) board.
• Deskana subscribed.

This is done. Updating task information for posterity.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL