Page MenuHomePhabricator

[Regression 1.27.0-wmf.21] Quick Edit button in the math popup in VE dies on load
Closed, ResolvedPublic1 Story Points

Description

When you right click on a maths formula in VE a dialog comes up with button to Quick Edit and Edit. Clicking Edit works fine but Quick Edit does nothing. Look at the console its generating an error

VM513:674 Uncaught TypeError: this.context.getSurface(...).executeComamnd is not a function
ve.ui.MWMathContextItem.onInlineEditButtonClick @ VM513:674
oo.EventEmitter.emit @ VM488:38
OO.ui.mixin.ButtonElement.onClick @ load.php?debug=false&lang=en&modules=ext.visualEditor.core|oojs-ui-core&skin=vector&version=11039da…:723
jQuery.event.dispatch @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Y5KlhSn2:65
elemData.handle @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Y5KlhSn2:60

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2016, 11:29 PM

It looks like there is a typo in "executeComamnd" which I guess should be "executeCommand".

Jdforrester-WMF renamed this task from Quick Edit button in the math popup in VE does nothing to [Regression] Quick Edit button in the math popup in VE dies on load.May 26 2016, 4:20 PM
Jdforrester-WMF reopened this task as Open.
Jdforrester-WMF triaged this task as Unbreak Now! priority.
Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptMay 26 2016, 4:20 PM

Change 290967 had a related patch set uploaded (by Jforrester):
Follow-up 3f456b1: Fix typo in function call

https://gerrit.wikimedia.org/r/290967

Jdforrester-WMF renamed this task from [Regression] Quick Edit button in the math popup in VE dies on load to [Regression 1.27.0-wmf.21] Quick Edit button in the math popup in VE dies on load.May 26 2016, 4:31 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF set the point value for this task to 1.

Change 290970 had a related patch set uploaded (by Jforrester):
Follow-up 3f456b1: Fix typo in function call

https://gerrit.wikimedia.org/r/290970

Change 290967 merged by jenkins-bot:
Follow-up 3f456b1: Fix typo in function call

https://gerrit.wikimedia.org/r/290967

Physikerwelt moved this task from Incoming to VisualEditor on the Math board.May 26 2016, 4:46 PM

Change 290970 merged by jenkins-bot:
Follow-up 3f456b1: Fix typo in function call

https://gerrit.wikimedia.org/r/290970

Change 290971 merged by jenkins-bot:
Follow-up 3f456b1: Fix typo in function call

https://gerrit.wikimedia.org/r/290971