Page MenuHomePhabricator
Create Task
Maniphest T132736

[Regression 1.27.0-wmf.21] Quick Edit button in the math popup in VE dies on load
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When you right click on a maths formula in VE a dialog comes up with button to Quick Edit and Edit. Clicking Edit works fine but Quick Edit does nothing. Look at the console its generating an error

VM513:674 Uncaught TypeError: this.context.getSurface(...).executeComamnd is not a function
ve.ui.MWMathContextItem.onInlineEditButtonClick @ VM513:674
oo.EventEmitter.emit @ VM488:38
OO.ui.mixin.ButtonElement.onClick @ load.php?debug=false&lang=en&modules=ext.visualEditor.core|oojs-ui-core&skin=vector&version=11039da…:723
jQuery.event.dispatch @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Y5KlhSn2:65
elemData.handle @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=Y5KlhSn2:60

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Mathwmf/1.28.0-wmf.3+1 -1Follow-up 3f456b1: Fix typo in function call
mediawiki/extensions/MathREL1_27+1 -1Follow-up 3f456b1: Fix typo in function call
mediawiki/extensions/Mathmaster+1 -1Follow-up 3f456b1: Fix typo in function call
Customize query in gerrit

Related Objects

Event Timeline

SalixAlba created this task.Apr 14 2016, 11:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2016, 11:29 PM
SalixAlba added a comment.Apr 14 2016, 11:31 PM

It looks like there is a typo in "executeComamnd" which I guess should be "executeCommand".

Physikerwelt closed this task as a duplicate of T118435: [Regression] When using MathML mode, the "quick editor" edit box is missing.Apr 14 2016, 11:43 PM
Physikerwelt mentioned this in T118435: [Regression] When using MathML mode, the "quick editor" edit box is missing.
Jdforrester-WMF renamed this task from Quick Edit button in the math popup in VE does nothing to [Regression] Quick Edit button in the math popup in VE dies on load.May 26 2016, 4:20 PM
Jdforrester-WMF reopened this task as Open.
Jdforrester-WMF triaged this task as Unbreak Now! priority.
Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptMay 26 2016, 4:20 PM
gerritbot added a subscriber: gerritbot.May 26 2016, 4:23 PM

Change 290967 had a related patch set uploaded (by Jforrester):
Follow-up 3f456b1: Fix typo in function call

https://gerrit.wikimedia.org/r/290967

gerritbot added a project: Patch-For-Review.May 26 2016, 4:23 PM
Jdforrester-WMF renamed this task from [Regression] Quick Edit button in the math popup in VE dies on load to [Regression 1.27.0-wmf.21] Quick Edit button in the math popup in VE dies on load.May 26 2016, 4:31 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF set the point value for this task to 1.
gerritbot added a comment.May 26 2016, 4:31 PM

Change 290970 had a related patch set uploaded (by Jforrester):
Follow-up 3f456b1: Fix typo in function call

https://gerrit.wikimedia.org/r/290970

gerritbot added a comment.May 26 2016, 4:45 PM

Change 290967 merged by jenkins-bot:
Follow-up 3f456b1: Fix typo in function call

https://gerrit.wikimedia.org/r/290967

Physikerwelt moved this task from Inbox to VisualEditor on the Math board.May 26 2016, 4:46 PM
gerritbot added a comment.May 26 2016, 4:58 PM

Change 290970 merged by jenkins-bot:
Follow-up 3f456b1: Fix typo in function call

https://gerrit.wikimedia.org/r/290970

Jdforrester-WMF closed this task as Resolved.May 26 2016, 5:21 PM
Jdforrester-WMF edited projects, added MW-1.28-release (WMF-deploy-2016-05-24_(1.28.0-wmf.3)), MW-1.28-release (WMF-deploy-2016-05-31_(1.28.0-wmf.4)); removed Patch-For-Review.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.May 26 2016, 6:59 PM
gerritbot added a comment.May 26 2016, 11:27 PM

Change 290971 merged by jenkins-bot:
Follow-up 3f456b1: Fix typo in function call

https://gerrit.wikimedia.org/r/290971

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).May 31 2016, 11:01 PM
Ryasmeen added a project: Verified.Jun 7 2016, 2:42 PM
Ryasmeen added projects: Verified-in-Phase0, Verified-in-Phase2.Jun 7 2016, 2:44 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL