Page MenuHomePhabricator
Create Task
Maniphest T132803

App sees old content right after edit
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When RESTBase is enabled it takes a while after an edit for the content to be generated. There is not much left we can do on the RB side.

We could add something to the app code to ensure that after a successful edit the app retries to get a new revision of the page. Until then keep spinning or show a Snackbar.

This is a follow up of T123938.

Details

SubjectRepoBranchLines +/-
Add a small artificial delay after saving an edit.apps/android/wikipediamaster+7 -0
Customize query in gerrit

Related Objects

Event Timeline

• bearND created this task.Apr 15 2016, 4:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2016, 4:40 PM
• bearND mentioned this in T123938: [Bug] Edits made with mobile content service enabled show old page copy.Apr 15 2016, 4:42 PM
• KHammerstein subscribed.Apr 20 2016, 7:50 PM
Dbrant moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.Apr 20 2016, 7:50 PM
• bearND added subscribers: • mobrovac, • GWicke.Apr 22 2016, 3:45 PM

@mobrovac @GWicke Would it be possible to send a specific HTTP header to the server that would block the response until the revision of a page changes and generation of the next revision is complete?

• mobrovac added a comment.Apr 27 2016, 7:42 AM
In T132803#2230684, @bearND wrote:

@mobrovac @GWicke Would it be possible to send a specific HTTP header to the server that would block the response until the revision of a page changes and generation of the next revision is complete?

Nope, that's not in line with the REST philosophy, unfortunately. The original problem is an artefact of the jobqueue being backlogged. We are now in the process of transferring the processing of updates to the change-propagation service which should minimise the amount of time it takes for the edit to become visible.

MBinder_WMF set the point value for this task to 1.May 18 2016, 7:21 PM
gerritbot subscribed.May 23 2016, 8:45 PM

Change 290349 had a related patch set uploaded (by Dbrant):
Add a small artificial delay after saving an edit.

https://gerrit.wikimedia.org/r/290349

gerritbot added a project: Patch-For-Review.May 23 2016, 8:45 PM
Dbrant added a project: Mobile-App-Android-Sprint-83-Bismuth.May 23 2016, 9:22 PM
Dbrant moved this task from To Do to Code Review on the Mobile-App-Android-Sprint-83-Bismuth board.May 23 2016, 9:25 PM
gerritbot added a comment.May 23 2016, 9:58 PM

Change 290349 merged by jenkins-bot:
Add a small artificial delay after saving an edit.

https://gerrit.wikimedia.org/r/290349

Dbrant moved this task from Code Review to Done on the Mobile-App-Android-Sprint-83-Bismuth board.May 24 2016, 12:45 AM
Dbrant closed this task as Resolved.May 24 2016, 6:16 PM
Dbrant claimed this task.
• Mholloway mentioned this in T141763: Wikipedia Android app does not show edit after saving.Sep 21 2016, 3:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL