Page MenuHomePhabricator

"Your edit was saved" sometimes does not appear when edits are saved
Closed, ResolvedPublic1 Story Points

Description

"Your edit was saved" sometimes does not appear when edits are saved.

Reported at https://en.wikipedia.org/w/index.php?oldid=715423941#.22Your_edit_was_saved.22_message_not_appearing_when_using_Visual_Editor.3F

I can't reproduce this in Safari 9.1/Mac OS 10.10.5, but @TheDJ can. Perhaps it's intermittent? Or requires a particular circumstance?

Event Timeline

Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 15 2016, 10:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Reproducing this problem seems to require switching editors during the edit.

So if you begin in WTE, switch to VE, then save, you don't get the PostEdit notification?

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 4:52 PM

ah, mediawiki.action.view.postEdit does not get loaded

Change 284252 had a related patch set uploaded (by Alex Monk):
Depend on postEdit code which we use after saving

https://gerrit.wikimedia.org/r/284252

Jdforrester-WMF triaged this task as High priority.Apr 19 2016, 7:12 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.

Change 284252 merged by jenkins-bot:
Depend on postEdit code which we use after saving

https://gerrit.wikimedia.org/r/284252