Page MenuHomePhabricator

MediaInfoViewTest::testPlaceholderIntegration fails in the Wikidata build
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/r/#/c/283630/
https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/58945/consoleFull

08:24:56 1) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testPlaceholderIntegration
08:24:56 Argument 2 passed to Wikibase\View\EntityViewPlaceholderExpander::__construct() must be an instance of User, Mock_Title_b40eb518 given
08:24:56 
08:24:56 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/src/EntityViewPlaceholderExpander.php:117
08:24:56 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:303
08:24:56 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:332

Became worse:
https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm/9742/console

13:49:01 1) Wikibase\MediaInfo\Tests\MediaWiki\EntityTypesTest::testViewFactoryCallback
13:49:01 Argument 1 passed to Wikibase\View\ViewFactory::newEntityTermsView() must implement interface Wikibase\View\EditSectionGenerator, string given
13:49:01 
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/src/ViewFactory.php:321
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/WikibaseMediaInfo.entitytypes.php:63
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/EntityTypesTest.php:116
13:49:01 
13:49:01 2) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetHtml with data set #0 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...))
13:49:01 getHtml() expects exactly 5 parameters, 4 given
13:49:01 
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:91
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/src/EntityView.php:104
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:154
13:49:01 
13:49:01 3) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetHtml with data set #1 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...), Wikibase\MediaInfo\DataModel\MediaInfoId Object (...))
13:49:01 getHtml() expects exactly 5 parameters, 4 given
13:49:01 
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:91
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/src/EntityView.php:104
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:154
13:49:01 
13:49:01 4) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetHtml with data set #2 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...), Wikibase\MediaInfo\DataModel\MediaInfoId Object (...), Wikibase\DataModel\Term\TermList Object (...), 'en', Wikibase\DataModel\Statement\StatementList Object (...))
13:49:01 getHtml() expects exactly 5 parameters, 4 given
13:49:01 
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:91
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/src/EntityView.php:104
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:154
13:49:01 
13:49:01 5) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetHtml with data set #3 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...), Wikibase\MediaInfo\DataModel\MediaInfoId Object (...), Wikibase\DataModel\Term\TermList Object (...), 'lkt')
13:49:01 getHtml() expects exactly 5 parameters, 4 given
13:49:01 
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:91
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/src/EntityView.php:104
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:154
13:49:01 
13:49:01 6) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetHtml with data set #4 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...), Wikibase\MediaInfo\DataModel\MediaInfoId Object (...), Wikibase\DataModel\Term\TermList Object (...), 'lkt', Wikibase\DataModel\Statement\StatementList Object (...))
13:49:01 getHtml() expects exactly 5 parameters, 4 given
13:49:01 
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:91
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/src/EntityView.php:104
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:154
13:49:01 
13:49:01 7) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetTitleHtml with data set #0 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...))
13:49:01 Argument 2 passed to Mock_EntityTermsView_768bbad0::getTitleHtml() must be an instance of Wikibase\DataModel\Term\Fingerprint, null given
13:49:01 
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:141
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:246
13:49:01 
13:49:01 8) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetTitleHtml with data set #1 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...), null, Wikibase\MediaInfo\DataModel\MediaInfoId Object (...))
13:49:01 Argument 2 passed to Mock_EntityTermsView_768bbad0::getTitleHtml() must be an instance of Wikibase\DataModel\Term\Fingerprint, Wikibase\MediaInfo\DataModel\MediaInfoId given
13:49:01 
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:141
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:246
13:49:01 
13:49:01 9) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetTitleHtml with data set #2 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...), Wikibase\DataModel\Term\TermList Object (...), Wikibase\MediaInfo\DataModel\MediaInfoId Object (...))
13:49:01 Argument 2 passed to Mock_EntityTermsView_768bbad0::getTitleHtml() must be an instance of Wikibase\DataModel\Term\Fingerprint, Wikibase\MediaInfo\DataModel\MediaInfoId given
13:49:01 
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:141
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:246
13:49:01 
13:49:01 10) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testGetTitleHtml with data set #3 (Wikibase\MediaInfo\DataModel\MediaInfo Object (...), Wikibase\DataModel\Term\TermList Object (...), Wikibase\MediaInfo\DataModel\MediaInfoId Object (...), 'lkt')
13:49:01 Argument 2 passed to Mock_EntityTermsView_768bbad0::getTitleHtml() must be an instance of Wikibase\DataModel\Term\Fingerprint, Wikibase\MediaInfo\DataModel\MediaInfoId given
13:49:01 
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:141
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:246
13:49:01 
13:49:01 11) Wikibase\MediaInfo\Tests\MediaWiki\View\MediaInfoViewTest::testPlaceholderIntegration
13:49:01 getHtml() expects exactly 5 parameters, 4 given
13:49:01 
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/src/View/MediaInfoView.php:91
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/Wikibase/view/src/EntityView.php:104
13:49:01 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Wikidata/extensions/MediaInfo/tests/phpunit/mediawiki/View/MediaInfoViewTest.php:326

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2016, 2:08 PM
JanZerebecki triaged this task as High priority.Apr 16 2016, 2:08 PM
JanZerebecki updated the task description. (Show Details)Apr 18 2016, 1:56 PM

Change 283971 had a related patch set uploaded (by Aude):
Remove $languageCode param when calling ViewFactory::newEntityTermsView

https://gerrit.wikimedia.org/r/283971