Page MenuHomePhabricator
Create Task
Maniphest T132850

Phabricator fails to save the new task in Safari browser, resulting in data loss
Closed, DeclinedPublic
Actions

Description

Safari on iOS 9 on iPhone 6S in portrait.

In Phab, I am creating a new task.
I write everything in the form.
I click the button Create new task.

Expected result:

Phab saves the new task and shows it to me.

Observed result:

Phab gives me a cryptic affront. See the screen photo to come. Among the meaningless signs, I discover some words that appear to be destined to a human: Reload the page and try again. But this is not clear. Reload which page? The previous page? The current page? If the previous page, then an action is missing before reloading it: going back to the previous page. If the current page, then what does "and try again" mean? I go back to the previous page. I find back my form, with all my writing, except the projects because of a bug. I add some projects again, and I send the form again. This gives me the same error. I go back again, and I click the button Reload in Safari. Phab asked me to reload, didn't he? The page gets reloaded, and the form is now empty! All my writing for the new task has been lost! Thank you Phabricator! [In reality, I had copied the description for the new task, but I was not supposed to.]

This is data loss, and Phabricator tricks the user into it!

It would be very nice to correct that horrible bug.

Thank you.

Nnemo

Related Objects

Event Timeline

Nnemo created this task.Apr 16 2016, 4:26 PM
Restricted Application added subscribers: scfc, Aklapper. · View Herald TranscriptApr 16 2016, 4:26 PM
Nnemo awarded a token.Apr 16 2016, 4:26 PM
Nnemo added a comment.Apr 16 2016, 5:16 PM

See the screen photo, affront from Phabricator:

Screen photo. Affront from Phabricator.

Nnemo updated the task description. (Show Details)Apr 16 2016, 5:22 PM
Krenair subscribed.Apr 16 2016, 5:22 PM

Phabricator showing an error does not necessarily mean Phabricator is wrong, the browser could be broken. Not all error messages are intended for the end user to be able to recover from.

Nnemo added a comment.Apr 16 2016, 5:32 PM
In T132850#2212251, @Krenair wrote:

Phabricator showing an error does not necessarily mean Phabricator is wrong, the browser could be broken.

In this case, I think that Phab is wrong. What reason does Phab have for giving this error?

Nnemo added a comment.Apr 16 2016, 5:42 PM

@Krenair

Besides, if the client has done something incorrectly and the server has a good reason to give an error, then the server has to give a meaningful error so that the user know what went wrong and how to do the action correctly and successfully.

valhallasw subscribed.Apr 16 2016, 6:39 PM

Combined with the earlier report T131697: Phabricator asks to log in but does not show SUL dialog, and traps the user (starting on www.mediawiki.org and ending on m.mediawiki.org?), this suggests to me there's a more generic issue with session handling in iOS 9 Safari rather than something Phabricator specific.

Aklapper triaged this task as Lowest priority.Apr 16 2016, 7:59 PM
Aklapper edited projects, added Phabricator (Upstream), Browser-Support-Apple-Safari; removed Phabricator.
Nnemo added a comment.Apr 20 2016, 7:17 PM
In T132850#2212335, @valhallasw wrote:

Combined with the earlier report T131697: Phabricator asks to log in but does not show SUL dialog, and traps the user (starting on www.mediawiki.org and ending on m.mediawiki.org?), this suggests to me there's a more generic issue with session handling in iOS 9 Safari rather than something Phabricator specific.

Maybe.

But good old forms work with Safari. If Phabricator did use standard robust forms, then these bugs would probably not occur.

I suspect that Phabricator programs some stuff for expiring, that this is a bad idea, that the expiration comes too soon, and that Phabricator handles the expiration incorrectly.

• mmodell subscribed.Apr 21 2016, 12:48 AM

This is related to some preventative measures that phabricator takes to guard against cross site request forgery. I haven't ever had this issue so indeed it would seem like it may be related to safari. I have submitted a task form after leaving it open for many hours between when I started writing it and when I finally submitted the form - no problem whatsoever.

Almost certainly not a universal phabricator bug but something specific to safari.

Aklapper renamed this task from Phabricator fails to save the new task, so data loss! to Phabricator fails to save the new task in Safari browser, resulting in data loss.Apr 23 2016, 9:46 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 23 2016, 9:46 AM
Danny_B added a project: Upstream.May 23 2016, 5:59 PM
Aklapper closed this task as Declined.Jun 26 2023, 7:47 AM
In T132850#2226120, @mmodell wrote:

Almost certainly not a universal phabricator bug but something specific to safari.

Resolving task as we do not plan to investigate this in Wikimedia.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL