cf. line 66 in https://gerrit.wikimedia.org/r/#/c/282675/1/src/storage/SprintColumnTransaction.php - for some reason, the reopened-points bit has just completely gone missing in the last update to sync with upstream stable. Is there any reason for this, or just inadvertent?
Description
Description
Related Objects
Related Objects
- Mentioned In
- T170154: "Points Closed Today" presents wrong value
Event Timeline
Comment Actions
Actually, sorry, this is fine; it seems like it's all driven from reopened tasks now.
Comment Actions
No, sorry, I take that back, it is broken.
I had originally thought including reopened points broke the first day, since we carry a patch to track task status based on status rather than column names. This had a bug which caused it to see all newly-opened tasks as reopened.
After fixing that, I now see reopened tasks having no effect on the burndown chart, until that line is uncommented.
Comment Actions
@fooishbar Thanks for the report. The reopened points never really worked properly, so I commented it out. The points remaining total incremented the reopened points twice, because a reopened task has multiple transactions for an "open" event in the time frame. I would have to make the logic to deduct reopened points from new task points on a per task basis to fix it (rather difficult to do with Phabricator's RDBMS madness). Rather than having a screwed up points remaining, it seems just easier to not aggregate reopened points at all. The sprint extension is not really a priority for me right now, so I am not sure that this fix will happen soon.
Comment Actions
Possibly related to this (I can open a separate task if you want):
If you drop a task in Done accidentally and then move it out, the task's points are still factored into "Points Closed Today"
Comment Actions
Resetting assignee as this is not actively being worked on (feel free to correct me if I am wrong).
Comment Actions
The Phabricator-Sprint-Extension is not under active development anymore and is unmaintained. It is about to be archived (see T275325). Reflecting reality by declining this ticket.
For the records, in the Wikimedia Phabricator installation, reports and charts have been customized (see e.g. https://phabricator.wikimedia.org/project/reports/5/ ).