Page MenuHomePhabricator
Create Task
Maniphest T132971

Implement Kartographer customization to match Wikivoyage existing map
Closed, ResolvedPublic
Actions

Description

Context
We need to simplify community's migration from the current wmflabs-hosted maps implementation to <mapframe>. For that, we should provide something similar to how it looks now, with similar behavior, using common.js and other similar mechanisms Mediawiki:Kartographer.{js,css} (since T133954).

Example
https://en.wikivoyage.org/wiki/Salzburg#Get_around
https://tools.wmflabs.org/wikivoyage/w/poimap2.php?lat=47.79990&lon=13.04288&zoom=15&layer=W&lang=en&name=Salzburg

EDIT 5/13/16: ( T132971#2294638 )
I created a github repository to share the prototype I have been working on:
https://github.com/juliengirault/wikivoyage-maps

EDIT 5/17/16: ( T132971#2302760 )
The prototype was deployed to English Wikivoyage this morning (.js, .css). See the Travellers' pub announcement.

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• JGiraultT132971 Implement Kartographer customization to match Wikivoyage existing map
 Resolved• JGiraultT134202 Keep a reference of leaflet layer objects created in the code, for internal/developer use
 ResolvedMaxSemT133954 Create a module that would load MediaWiki:Kartographer.{js|css} on pages with maps
 Resolved• JGiraultT136061 Fix incorrect title text of *Nearby articles* control (suggestions welcome)
 Resolved• JGiraultT136260 Match the style of maplink numbered boxes to the existing ones as used in WV
 ResolvedMaxSemT136890 Maplink extractMarkerCss does not extract the color hex code correctly
DeclinedYurikT137364 Migrate {{geo}} Wikivoyage template to <maplink> (with an icon)
 ResolvedYurikT137392 <maplink> event listener is not attached to elements outside of content
 ResolvedTheDJT137656 Migrate WV Template:PoiMap2detail to new maplink
 ResolvedYurikT134086 Allow map tags to get geodata from Kartotherian
 ResolvedYurikT134084 Provide osm mapdata service
 ResolvedYurikT134085 Implement quick shape retrieval from Postgres based on WikidataID
 ResolvedGehelT112423 Update osm2pgsql to 0.90+
 ResolvedYurikT138154 Implement shape simplification
 ResolvedMaxSemT138191 RFC: Define wiki markup for external geo data like OSM shapes
 ResolvedYurikT138739 make getMapGroupData() request same data only once
 Resolved• JGiraultT138971 Move the WV code from github to Kartographer
 Resolved• JGiraultT140253 Remove the migrated WV-specific code from the MW namespace

Event Timeline

Yurik created this task.Apr 18 2016, 9:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2016, 9:50 PM
Yurik moved this task from Unsorted to UI tasks on the Maps (Kartographer) board.Apr 18 2016, 9:51 PM
• JGirault created subtask T134202: Keep a reference of leaflet layer objects created in the code, for internal/developer use.May 2 2016, 9:38 PM
Yurik closed subtask T134202: Keep a reference of leaflet layer objects created in the code, for internal/developer use as Resolved.May 3 2016, 12:39 AM
• JGirault updated the task description. (Show Details)May 14 2016, 2:46 AM
• JGirault added a comment.May 14 2016, 4:23 AM

I created a github repository to share the prototype I have been working on:

https://github.com/juliengirault/wikivoyage-maps

Follow the README to install and generate the two files.
Then create Mediawiki:Kartographer.js and Mediawiki:Kartographer.css on your wiki and you should see the prototype.

Screenshots

Base map:

Screen Shot 2016-05-13 at 9.18.43 PM.png (836×938 px, 650 KB)

With Mapquest open tiles and Mapquest (labels) overlay:

Screen Shot 2016-05-13 at 9.19.12 PM.png (832×928 px, 1 MB)

• JGirault added a comment.May 17 2016, 8:00 PM

Exciting news: the prototype was deployed to English Wikivoyage this morning, using MediaWiki:Kartographer.js and MediaWiki:Kartographer.css.

@Yurik made a public announcement in the Travellers' pub. We hope to collect the first feedback and start tracking and fixing bugs.

• JGirault added a subtask: T133954: Create a module that would load MediaWiki:Kartographer.{js|css} on pages with maps.May 17 2016, 8:00 PM
• JGirault updated the task description. (Show Details)May 17 2016, 8:07 PM
Yurik added a project: Maps.May 17 2016, 8:34 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptMay 17 2016, 8:34 PM
Yurik moved this task from All map-related tasks to Kartographer on the Maps board.May 17 2016, 8:36 PM
Yurik added a comment.May 18 2016, 6:41 AM

First draft of the new Wikivoyage page is ready. The style of the boxes needs to be changed / moved into the CSS (otherwise it stays as blue, which is hard to see) -- I think it should be added to the Kartographer.css page: https://en.wikivoyage.org/wiki/User:Yurik/Sandbox/Salzburg

• JGirault mentioned this in T136055: Design *Nearby Articles* icon.May 24 2016, 12:30 AM
• JGirault created subtask T136061: Fix incorrect title text of *Nearby articles* control (suggestions welcome).May 24 2016, 1:06 AM
• JGirault mentioned this in T136362: Close control in MapDialog should be a Leaflet Control .May 26 2016, 9:27 PM
Yurik added a project: Maps-Sprint.May 27 2016, 3:01 PM
Yurik renamed this task from Prototype <mapframe> to match Wikivoyage existing map to Implement Kartographer customization to match Wikivoyage existing map.May 27 2016, 9:54 PM
Yurik moved this task from Backlog to In progress on the Maps-Sprint board.
Yurik added a subtask: T136260: Match the style of maplink numbered boxes to the existing ones as used in WV.May 27 2016, 10:30 PM
Yurik closed subtask T136260: Match the style of maplink numbered boxes to the existing ones as used in WV as Resolved.Jun 1 2016, 9:57 PM
Yurik reopened subtask T136260: Match the style of maplink numbered boxes to the existing ones as used in WV as Open.Jun 2 2016, 11:53 AM
• JGirault closed subtask T136061: Fix incorrect title text of *Nearby articles* control (suggestions welcome) as Resolved.Jun 3 2016, 9:27 PM
Yurik closed subtask T136260: Match the style of maplink numbered boxes to the existing ones as used in WV as Resolved.Jun 9 2016, 4:06 AM
Yurik added a subtask: T137364: Migrate {{geo}} Wikivoyage template to <maplink> (with an icon).Jun 9 2016, 4:12 AM
Yurik added a project: Epic.
Yurik moved this task from Kartographer to Wiki-related on the Maps board.Jun 12 2016, 3:13 AM
Yurik closed subtask T137364: Migrate {{geo}} Wikivoyage template to <maplink> (with an icon) as Resolved.Jun 16 2016, 12:20 AM
Yurik added a subtask: T137656: Migrate WV Template:PoiMap2detail to new maplink.Jun 16 2016, 12:23 AM
Yurik closed subtask T137656: Migrate WV Template:PoiMap2detail to new maplink as Resolved.Jun 16 2016, 12:39 AM
Yurik reopened subtask T137364: Migrate {{geo}} Wikivoyage template to <maplink> (with an icon) as Open.Jun 16 2016, 1:39 PM
Yurik reopened subtask T137656: Migrate WV Template:PoiMap2detail to new maplink as Open.
• JGirault added a subtask: T138971: Move the WV code from github to Kartographer.Jun 29 2016, 6:35 PM
• JGirault moved this task from In progress to Needs review on the Maps-Sprint board.Jun 30 2016, 8:11 AM
• JGirault closed subtask T138971: Move the WV code from github to Kartographer as Resolved.Jul 2 2016, 12:33 AM
• JGirault added a comment.EditedJul 18 2016, 5:03 PM

@Yurik shall we consider this one resolved? what about the 2 sub-tasks?
Edit: I saw they are marked "in progress" :)

Yurik closed this task as Resolved.Jul 18 2016, 7:48 PM

@JGirault yep, lets close it, and make the other two patches depend on T134086

TheDJ closed subtask T137364: Migrate {{geo}} Wikivoyage template to <maplink> (with an icon) as Declined.Mar 24 2020, 9:20 AM
TheDJ closed subtask T137656: Migrate WV Template:PoiMap2detail to new maplink as Resolved.Mar 22 2023, 2:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL