Page MenuHomePhabricator

GuidedTour registers a dependency on a key from Vector ('vector-view-edit') but doesn't depend on the skin (because you can't)
Closed, ResolvedPublic


23:12:46 1) ResourcesTest::testMissingMessages
23:12:46 Message 'vector-view-edit' required by 'ext.guidedTour.tour.firstedit' must exist
23:12:46 Failed asserting that false is true.
23:12:46 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/structure/ResourcesTest.php:103
23:12:46 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/MediaWikiTestCase.php:156

Messy (and blocking the unit test to assert that we don't do this).

@Catrope said to copy the message from the DOM, rather than use {{int:}}.


Related Gerrit Patches:
mediawiki/extensions/GuidedTour : masterCopy from DOM instead of using vector-view-edit

Event Timeline

Is there no way to depend on skins in Jenkins config? You can depend on extensions.

Let's just use $( '#ca-edit' ).text() or whatever it is that VE uses.

VisualEditor uses MediaWiki core's edit and create messages instead of Vector's.

key = pageExists ? 'edit' : 'create';
$el.text( mw.msg( key ) );

That's not the same text as vector-view-edit. I'll just copy the DOM instead.

Change 293159 had a related patch set uploaded (by Mattflaschen):
Copy from DOM instead of using vector-view-edit

Change 293159 merged by jenkins-bot:
Copy from DOM instead of using vector-view-edit

This is now fixed, thanks; leaving to the team to mark as Resolved.

All changes are in the code. Additionally checked the guided tour in betalabs - looks fine.

Jdforrester-WMF closed this task as Resolved.Jun 10 2016, 2:34 PM