GuidedTour registers a dependency on a key from Vector ('vector-view-edit') but doesn't depend on the skin (because you can't)
Closed, ResolvedPublic
Actions

Description

https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/59144/consoleFull:

23:12:46 1) ResourcesTest::testMissingMessages
23:12:46 Message 'vector-view-edit' required by 'ext.guidedTour.tour.firstedit' must exist
23:12:46 Failed asserting that false is true.
23:12:46 
23:12:46 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/structure/ResourcesTest.php:103
23:12:46 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/MediaWikiTestCase.php:156

https://github.com/wikimedia/mediawiki-extensions-GuidedTour/blob/012d812e4002fb4b0113eb3c02313cdf471ffefa/modules/tours/firsteditve.js#L44

Messy (and blocking the unit test to assert that we don't do this).

@Catrope said to copy the message from the DOM, rather than use {{int:}}.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Copy from DOM instead of using vector-view-edit	mediawiki/extensions/GuidedTour	master	+6 -5

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krinkle	T129976 Provide a structural unit test to confirm each module message exists
		Resolved		• Mattflaschen-WMF	T132989 GuidedTour registers a dependency on a key from Vector ('vector-view-edit') but doesn't depend on the skin (because you can't)

Event Timeline

Jdforrester-WMF created this task.Apr 18 2016, 11:45 PM

Is there no way to depend on skins in Jenkins config? You can depend on extensions.

Let's just use $( '#ca-edit' ).text() or whatever it is that VE uses.

• Mattflaschen-WMF updated the task description. (Show Details)Apr 25 2016, 9:43 PM

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 29 2016, 12:41 AM

VisualEditor uses MediaWiki core's edit and create messages instead of Vector's.

https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/50f6f466ea17a8d5778e89c7fbd443bbea94bfc3/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js#L188-L193

key = pageExists ? 'edit' : 'create';
$el.text( mw.msg( key ) );

"edit",
"create"

That's not the same text as vector-view-edit. I'll just copy the DOM instead.

Change 293159 had a related patch set uploaded (by Mattflaschen):
Copy from DOM instead of using vector-view-edit

https://gerrit.wikimedia.org/r/293159

gerritbot added a project: Patch-For-Review.Jun 7 2016, 8:38 PM

• Mattflaschen-WMF moved this task from Ready for Pickup to Needs Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jun 7 2016, 8:39 PM

Change 293159 merged by jenkins-bot:
Copy from DOM instead of using vector-view-edit

https://gerrit.wikimedia.org/r/293159

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)).Jun 8 2016, 5:00 PM

This is now fixed, thanks; leaving to the team to mark as Resolved.

Catrope moved this task from Needs Review to QA Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jun 9 2016, 9:20 AM

All changes are in the code. Additionally checked the guided tour in betalabs - looks fine.

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jun 9 2016, 10:13 PM

Jdforrester-WMF closed this task as Resolved.Jun 10 2016, 2:34 PM

kostajh mentioned this in T290627: [enwiki] Suggested edits: a blue dot displayed on Edit source tab.Sep 23 2021, 1:31 PM

GuidedTour registers a dependency on a key from Vector ('vector-view-edit') but doesn't depend on the skin (because you can't)Closed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

GuidedTour registers a dependency on a key from Vector ('vector-view-edit') but doesn't depend on the skin (because you can't)
Closed, ResolvedPublic
Actions

Related Objects
Search...