Results from @bmansurov

In T67103#2185211, @bmansurov wrote:

OK, here is my analysis so far:

1. ext.popups.core.js

Not tested:

• mw.popups.removeTooltips
• mw.popups.setupTriggers
• mw.popups.selectPopupElements

Tested:

• mw.popups.getTitle

2. ext.popups.renderer.article.js

Not tested:

• article.createPopup
• article.removeParensFromText
• article.createSVGTag
• article.createThumbnail
• article.createSvgImageThumbnail
• article.createImgThumbnail
• article.getOffset
• article.getClasses
• article.processPopup

Tested:

• article.getProcessedElements
• mw.popups.render.getClosestYPosition

3. These files are not tested: ext.popups.disablenavpop.js, ext.popups.logger.js, ext.popups.settings.js.

In T67103#2204868, @bmansurov wrote:

I think this task is definitely more than a 3 pointer (probably an 8) because the extension is covered sparsely.

@bmansurov Did you review all the files?

I see there are for example

• resources/ext.popups.renderer/desktopRenderer.js
• resources/ext.popups.renderer/mobileRenderer.js

They are not on the analysis. Is there a reason for that? :) Should we reopen this?

@bmansurov I think they don't have any tests, at the very least the would need some browser tests to check they render in the different environments, what do you think.

@Jhernandez you're right. I totally missed those two folders and all files in them. No need to re-open as those have already been caught by you.