Get browser tests running in beta labs with every patch submitted.
Description
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | Jdlrobson | T111329 [GOAL] Page previews on mobileweb | |||
| Resolved | phuedx | T133947 [EPIC] Reduce bloat of Page Previews RL module(s) | |||
| Resolved | Jdlrobson | T144522 [EPIC] Hovercards technical debt and quality enhancements | |||
| Resolved | Jdlrobson | T67103 [EPIC] Hovercards: Test Coverage | |||
| Resolved | Jdlrobson | T133018 Set up browser tests running on CI (jenkins) for Hovercards | |||
| Resolved | Jdlrobson | T133019 Create browser tests for hovering link and showing hovercard |
Event Timeline
Change 283568 had a related patch set uploaded (by Jhernandez):
Create Popups jenkins job
@JanZerebecki can you have a look again when you have some time please? https://gerrit.wikimedia.org/r/#/c/283568/
Thanks!
CI is configured to trigger the browser tests. I have hit recheck on the last merged patch https://gerrit.wikimedia.org/r/#/c/283566/ but the job fails :( https://integration.wikimedia.org/ci/job/mwext-mw-selenium/5661/console
Seems it depends on the beta features extension isn't it? And we dont have a good way to inject dependencies in the mwext-selenium job grrr
Change 284442 had a related patch set uploaded (by Hashar):
[Popups] depends on BetaFeatures
Popups is now injected as a dependency but the job fails with:
unable to locate element, using {:css=>"#mw-input-wppopups", :tag_name=>"input or textarea", :type=>"(any text type)"}https://integration.wikimedia.org/ci/job/mwext-mw-selenium/5662/console
From the build screenshot, there is now beta feature for HoverCards. Maybe it needs to be explicitly enabled?
Change 284443 had a related patch set uploaded (by Hashar):
[WIP] attempt to always enable beta feature
When I force enable Popups to be a beta features ( https://gerrit.wikimedia.org/r/#/c/284443/ ) the test job has two scenarii passing https://integration.wikimedia.org/ci/job/mwext-mw-selenium/5663/console though one still fails with:
00:00:35.894 Then I should see a hover card # features/support/step_definitions/popups_core.rb:11 00:00:35.894 expected visible? to return true, got false (RSpec::Expectations::ExpectationNotMetError) 00:00:35.894 ./features/support/step_definitions/popups_core.rb:12:in `/^I should see a hover card$/' 00:00:35.894 features/popups_core.feature:11:in `Then I should see a hover card'
Maybe we should make the job experimental for now? Ie have it triggered on demand by people commenting in Gerrit check experimental.