Page MenuHomePhabricator

Set up browser tests running on CI (jenkins) for Hovercards
Closed, ResolvedPublic


Get browser tests running in beta labs with every patch submitted.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 283568 had a related patch set uploaded (by Jhernandez):
Create Popups jenkins job

Change 283568 merged by jenkins-bot:
Run Popups browser tests per patch

CI is configured to trigger the browser tests. I have hit recheck on the last merged patch but the job fails :(

Seems it depends on the beta features extension isn't it? And we dont have a good way to inject dependencies in the mwext-selenium job grrr

Change 284442 had a related patch set uploaded (by Hashar):
[Popups] depends on BetaFeatures

Change 284442 merged by jenkins-bot:
[Popups] depends on BetaFeatures

Popups is now injected as a dependency but the job fails with:

unable to locate element, using {:css=>"#mw-input-wppopups", :tag_name=>"input or textarea", :type=>"(any text type)"}

From the build screenshot, there is now beta feature for HoverCards. Maybe it needs to be explicitly enabled?

Change 284443 had a related patch set uploaded (by Hashar):
[WIP] attempt to always enable beta feature

When I force enable Popups to be a beta features ( ) the test job has two scenarii passing though one still fails with:

00:00:35.894     Then I should see a hover card               # features/support/step_definitions/popups_core.rb:11
00:00:35.894       expected visible? to return true, got false (RSpec::Expectations::ExpectationNotMetError)
00:00:35.894       ./features/support/step_definitions/popups_core.rb:12:in `/^I should see a hover card$/'
00:00:35.894       features/popups_core.feature:11:in `Then I should see a hover card'

Maybe we should make the job experimental for now? Ie have it triggered on demand by people commenting in Gerrit check experimental.

bmansurov added a subscriber: bmansurov.

Change 284443 abandoned by Hashar:
[WIP] attempt to always enable beta feature

Jdlrobson claimed this task.
Jdlrobson removed a project: Patch-For-Review.