Page MenuHomePhabricator

Set up browser tests running on CI (jenkins) for Hovercards
Closed, ResolvedPublic

Description

Get browser tests running in beta labs with every patch submitted.

Event Timeline

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptApr 19 2016, 9:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 283568 had a related patch set uploaded (by Jhernandez):
Create Popups jenkins job

https://gerrit.wikimedia.org/r/283568

@bmansurov Jan has some comments on the patch.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 10:36 PM
phuedx added a subscriber: phuedx.Apr 20 2016, 8:36 AM

This is waiting on someone with +2 on integration/config.

@JanZerebecki can you have a look again when you have some time please? https://gerrit.wikimedia.org/r/#/c/283568/

Thanks!

Change 283568 merged by jenkins-bot:
Run Popups browser tests per patch

https://gerrit.wikimedia.org/r/283568

hashar added a subscriber: hashar.Apr 20 2016, 10:55 AM

CI is configured to trigger the browser tests. I have hit recheck on the last merged patch https://gerrit.wikimedia.org/r/#/c/283566/ but the job fails :( https://integration.wikimedia.org/ci/job/mwext-mw-selenium/5661/console

Seems it depends on the beta features extension isn't it? And we dont have a good way to inject dependencies in the mwext-selenium job grrr

Change 284442 had a related patch set uploaded (by Hashar):
[Popups] depends on BetaFeatures

https://gerrit.wikimedia.org/r/284442

Change 284442 merged by jenkins-bot:
[Popups] depends on BetaFeatures

https://gerrit.wikimedia.org/r/284442

Popups is now injected as a dependency but the job fails with:

unable to locate element, using {:css=>"#mw-input-wppopups", :tag_name=>"input or textarea", :type=>"(any text type)"}

https://integration.wikimedia.org/ci/job/mwext-mw-selenium/5662/console

From the build screenshot, there is now beta feature for HoverCards. Maybe it needs to be explicitly enabled?

Change 284443 had a related patch set uploaded (by Hashar):
[WIP] attempt to always enable beta feature

https://gerrit.wikimedia.org/r/284443

When I force enable Popups to be a beta features ( https://gerrit.wikimedia.org/r/#/c/284443/ ) the test job has two scenarii passing https://integration.wikimedia.org/ci/job/mwext-mw-selenium/5663/console though one still fails with:

00:00:35.894     Then I should see a hover card               # features/support/step_definitions/popups_core.rb:11
00:00:35.894       expected visible? to return true, got false (RSpec::Expectations::ExpectationNotMetError)
00:00:35.894       ./features/support/step_definitions/popups_core.rb:12:in `/^I should see a hover card$/'
00:00:35.894       features/popups_core.feature:11:in `Then I should see a hover card'

Maybe we should make the job experimental for now? Ie have it triggered on demand by people commenting in Gerrit check experimental.

bmansurov removed bmansurov as the assignee of this task.Apr 20 2016, 12:42 PM
bmansurov added a subscriber: bmansurov.

Change 284443 abandoned by Hashar:
[WIP] attempt to always enable beta feature

https://gerrit.wikimedia.org/r/284443

Jdlrobson closed this task as Resolved.Apr 20 2016, 7:55 PM
Jdlrobson claimed this task.
Jdlrobson removed a project: Patch-For-Review.