Tested:
- mw.popups.setupTriggers
- mw.popups.getTitle
- mw.popups.removeTooltips
- mw.popups.selectPopupElements
Tested:
mediawiki/extensions/Popups : master | Add test to cover mw.popups.setupTriggers |
mediawiki/extensions/Popups : master | Add missing mw.popups.selectPopupElements test case |
mediawiki/extensions/Popups : master | Add QUnit tests to cover ext.popups.core.js |
Status | Assigned | Task | ||
---|---|---|---|---|
Declined | Jdlrobson | T111329 [GOAL] Page previews on mobileweb | ||
Resolved | phuedx | T133947 [EPIC] Reduce bloat of Page Previews RL module(s) | ||
Resolved | Jdlrobson | T144522 [EPIC] Hovercards technical debt and quality enhancements | ||
Resolved | Jdlrobson | T67103 [EPIC] Hovercards: Test Coverage | ||
Resolved | Jdlrobson | T133020 Unit test ext.popups.core.js | ||
Resolved | Jdlrobson | T133163 BetaFeatures test failure |
Change 283348 had a related patch set uploaded (by Jhernandez):
Add QUnit tests to cover ext.popups.core.js
Change 284873 had a related patch set uploaded (by Phuedx):
Add missing mw.popups.selectPopupElements test case
Change 284876 had a related patch set uploaded (by Phuedx):
Add test to cover mw.popups.setupTriggers
Not tested:
- mw.popups.setupTriggers
After a few attempts at getting 284876 to pass in the build environment, I can only conclude that mw.popups.scrolled is being set to true and the "trigger handler" (event listener) is short-circuiting.
I abandoned the change as it felt awkward to override the global state or to manipulate the scroll position of the browser to ensure that the test passes.
Change 284873 merged by jenkins-bot:
Add missing mw.popups.selectPopupElements test case
Those tests should probably call HTMLForm::loadData() before HTMLForm::getHTML(). Nevertheless, https://gerrit.wikimedia.org/r/#/c/285623/ should fix them.