Page MenuHomePhabricator

Unit test ext.popups.settings.js
Closed, ResolvedPublic3 Story Points

Description

No coverage whatsoever. Unit test properly.

This module has mixed functionality from a view (unit testable) and other functionality that should be tested with acceptance tests (browser tests) like the add browser footer link thingy.

This task is about unit testing the parts that make sense. There's a followup task for adding browser tests for the addfooterlink thing.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2016, 9:41 AM
Jhernandez set the point value for this task to 3.Apr 19 2016, 3:52 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 3:52 PM
Jhernandez updated the task description. (Show Details)Apr 19 2016, 4:01 PM
Jhernandez updated the task description. (Show Details)

Change 286024 had a related patch set uploaded (by Bmansurov):
Add QUnit test for ext.popups.settings

https://gerrit.wikimedia.org/r/286024

Change 286024 merged by jenkins-bot:
Add QUnit test for ext.popups.settings

https://gerrit.wikimedia.org/r/286024

phuedx closed this task as Resolved.Apr 29 2016, 9:04 AM
phuedx claimed this task.
phuedx added a subscriber: phuedx.

Since this is a technical task…