Maniphest T133025

Unit test ext.popups.settings.js
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

No coverage whatsoever. Unit test properly.

This module has mixed functionality from a view (unit testable) and other functionality that should be tested with acceptance tests (browser tests) like the add browser footer link thingy.

This task is about unit testing the parts that make sense. There's a followup task for adding browser tests for the addfooterlink thing.

Details

	Subject	Repo	Branch	Lines +/-
	Add QUnit test for `ext.popups.settings`	mediawiki/extensions/Popups	master	+99 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		Jdlrobson	T111329 [GOAL] Page previews on mobileweb
		Resolved		phuedx	T133947 [EPIC] Reduce bloat of Page Previews RL module(s)
		Resolved		Jdlrobson	T144522 [EPIC] Hovercards technical debt and quality enhancements
		Resolved		Jdlrobson	T67103 [EPIC] Hovercards: Test Coverage
		Invalid		None	T133055 Split ext.popups.settings.js in units
		Resolved		phuedx	T133025 Unit test ext.popups.settings.js
		Resolved		phuedx	T133054 Create browser test for add footer link in ext.popups.settings.js
		Resolved		Jdlrobson	T133163 BetaFeatures test failure

Event Timeline

• Jhernandez created this task.Apr 19 2016, 9:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2016, 9:41 AM

• Jhernandez moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.Apr 19 2016, 9:43 AM

• Jhernandez set the point value for this task to 3.Apr 19 2016, 3:52 PM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 3:52 PM

• Jhernandez updated the task description. (Show Details)Apr 19 2016, 4:01 PM

• Jhernandez updated the task description. (Show Details)

• Jhernandez moved this task from To Do to Needs Analysis on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.Apr 19 2016, 4:11 PM

MBinder_WMF added a project: Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters.Apr 19 2016, 8:38 PM

• Jhernandez added a subtask: T133054: Create browser test for add footer link in ext.popups.settings.js.Apr 20 2016, 3:32 PM

• Jhernandez added a parent task: T133055: Split ext.popups.settings.js in units.

dr0ptp4kt moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.Apr 20 2016, 3:58 PM

• Jhernandez moved this task from Needs Analysis to Ignore on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.Apr 21 2016, 4:59 PM

Danny_B moved this task from Unsorted to Test coverage on the Technical-Debt board.Apr 21 2016, 8:52 PM

• bmansurov claimed this task.Apr 26 2016, 9:53 PM

• bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.

MBinder_WMF added a project: Web-Team-Backlog.Apr 27 2016, 5:10 PM

MBinder_WMF moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.Apr 27 2016, 5:13 PM

phuedx closed subtask T133054: Create browser test for add footer link in ext.popups.settings.js as Resolved.Apr 28 2016, 8:58 AM

Change 286024 had a related patch set uploaded (by Bmansurov):
Add QUnit test for ext.popups.settings

https://gerrit.wikimedia.org/r/286024

gerritbot added a project: Patch-For-Review.Apr 28 2016, 8:13 PM

• bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.Apr 28 2016, 8:13 PM

Change 286024 merged by jenkins-bot:
Add QUnit test for ext.popups.settings

https://gerrit.wikimedia.org/r/286024

• bmansurov removed • bmansurov as the assignee of this task.Apr 28 2016, 8:47 PM

• bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.

• bmansurov subscribed.

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-05-03_(1.27.0-wmf.23)).Apr 28 2016, 9:00 PM

Since this is a technical task…

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.May 9 2016, 4:39 PM