Page MenuHomePhabricator

[Task] Handle cases where assiging a fresh ID to a new entity expects numeric entity IDs
Closed, DeclinedPublic

Description

From https://phabricator.wikimedia.org/T125822#2215088:

  • Places in the code when assigning a fresh id to a new entity that expect numeric entity ids and expect methods like ItemId::newFromNumber exist for MediaInfoId

Event Timeline

Change 285905 had a related patch set uploaded (by Adrian Heine):
Temporarily support numeric entity in MediaInfo::setId

https://gerrit.wikimedia.org/r/285905

Since MediaInfo entities are currently using arbitrary, prefixed numeric entity ids, I propose to make it work with the code we already have. Depending on how we implement creation of MediaInfo entities, we won't even need to change WikibaseRepo. The code that's currently responsible for assigning fresh ids just does nothing if an entity already has an id.

https://gerrit.wikimedia.org/r/#/c/285905/

Change 285905 merged by jenkins-bot:
Temporarily support numeric entity in MediaInfo::setId

https://gerrit.wikimedia.org/r/285905

Change 277582 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Only use numeric ids on supported entity types

https://gerrit.wikimedia.org/r/277582

Change 277582 merged by jenkins-bot:
Only use numeric ids on supported entity types

https://gerrit.wikimedia.org/r/277582