[Task] Handle cases where assiging a fresh ID to a new entity expects numeric entity IDs
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	Tobi_WMDE_SW
	Apr 19 2016, 2:32 PM

Description

From https://phabricator.wikimedia.org/T125822#2215088:

Places in the code when assigning a fresh id to a new entity that expect numeric entity ids and expect methods like ItemId::newFromNumber exist for MediaInfoId

Details

	Subject	Repo	Branch	Lines +/-
	Only use numeric ids on supported entity types	mediawiki/extensions/Wikibase	master	+15 -3
	Temporarily support numeric entity in MediaInfo::setId	mediawiki/extensions/WikibaseMediaInfo	master	+16 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Resolved		daniel	T134473 Create MediaInfo / Linking multimedia files to their mediainfo entity (second prototype)
Resolved		Tobi_WMDE_SW	T125822 [Epic] Basic first prototype for structured data support for Commons
Declined		adrianheine	T133044 [Task] Handle cases where assiging a fresh ID to a new entity expects numeric entity IDs

Event Timeline

Tobi_WMDE_SW created this task.Apr 19 2016, 2:32 PM

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Apr 21 2016, 11:11 AM

Lydia_Pintscher moved this task from in progress to consider for next sprint on the Wikidata board.

Tobi_WMDE_SW moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-04-26 board.Apr 26 2016, 1:15 PM

Change 285905 had a related patch set uploaded (by Adrian Heine):
Temporarily support numeric entity in MediaInfo::setId

https://gerrit.wikimedia.org/r/285905

gerritbot added a project: Patch-For-Review.May 2 2016, 8:44 AM

adrianheine mentioned this in rEWBI0912d0830758: Temporarily support numeric entity in MediaInfo::setId.May 2 2016, 8:44 AM

Since MediaInfo entities are currently using arbitrary, prefixed numeric entity ids, I propose to make it work with the code we already have. Depending on how we implement creation of MediaInfo entities, we won't even need to change WikibaseRepo. The code that's currently responsible for assigning fresh ids just does nothing if an entity already has an id.

https://gerrit.wikimedia.org/r/#/c/285905/

adrianheine claimed this task.May 2 2016, 8:44 AM

adrianheine moved this task from Backlog to Review on the Wikidata-Sprint-2016-04-26 board.

thiemowmde mentioned this in rEWBI12110cf7b360: Temporarily support numeric entity in MediaInfo::setId.May 2 2016, 9:30 AM

Change 285905 merged by jenkins-bot:
Temporarily support numeric entity in MediaInfo::setId

https://gerrit.wikimedia.org/r/285905

adrianheine closed this task as Declined.May 3 2016, 2:30 PM

adrianheine moved this task from Review to Done on the Wikidata-Sprint-2016-04-26 board.

Change 277582 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Only use numeric ids on supported entity types

https://gerrit.wikimedia.org/r/277582

Change 277582 merged by jenkins-bot:
Only use numeric ids on supported entity types